REST-Tests: Use Dedicated AntBuilders #35576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use dedicated AntBuilder everywhere since AntBuilder is not threadsafe * Closes elastic#33778
original-brownbear
added
>test
Collaborator
|
Pinging @elastic/es-core-infra |
Contributor
Author
|
Jenkins test this |
alpar-t
approved these changes
Nov 15, 2018
Contributor
alpar-t
left a comment
alpar-t
left a comment
There was a problem hiding this comment.
It's worth a shot.
ClsuterFormationTasks is going away to make room for --parallel :)
Contributor
Author
|
@atorok thanks! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Nov 15, 2018
* REST-Tests: Use Dedicated AntBuilders * Use dedicated AntBuilder everywhere since AntBuilder is not threadsafe * Closes elastic#33778
original-brownbear
added a commit
that referenced
this pull request
Nov 15, 2018
* REST-Tests: Use Dedicated AntBuilders * Use dedicated AntBuilder everywhere since AntBuilder is not threadsafe * Closes #33778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@atorok see my explanation here. The execution order of starting
node 0and waiting fornode 1is off despite the Gradle logging to the contrary (both are Ant tasks). This is my best guess, based on the fact thatAntBuilderisn't thread-safe and the fact that Gradle logs different worker threads for thenode1.configureandnode0.starttasks in e.g. this build https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+6.5+bwc-tests/36/console (starts node 0 in thread 9,5 but configures node1 in 10,5?).... that said, I guess this change may be valuable regardless of #33778 to move us forward in terms of enabling
--parallel? :)