Skip to content

Conversation

@original-brownbear
Copy link
Contributor

* Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait
for its own transport.ports file for 30s.
* Closes elastic#35456
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests v7.0.0 :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v6.6.0 labels Nov 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, but I'm not sure about the fix. I think this only affects the rolling-upgrade tests, in which Gradle believes us to have a one-node cluster but the minimum_master_nodes setting indicates otherwise. I think it'd be better to say if (minimumMasterNodes > 1) ...?

I think we should consider, as a followup, moving the writing of the transport ports file earlier in the node startup and getting rid of the initial_state_timeout overrides like this.

@original-brownbear
Copy link
Contributor Author

@DaveCTurner

(minimumMasterNodes > 1)

Sure :) That works too fixing.

I think we should consider, as a followup, moving the writing of the transport ports file earlier in the node startup and getting rid of the initial_state_timeout overrides like this.

Yes please :)

@original-brownbear
Copy link
Contributor Author

Fixed :)

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear merged commit 7919b66 into elastic:master Nov 13, 2018
@original-brownbear original-brownbear deleted the 35456 branch November 13, 2018 12:19
@original-brownbear
Copy link
Contributor Author

@DaveCTurner thanks!

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Nov 14, 2018
* DISCOVERY: 0s Initial State Timeout in Tests

* Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait
for its own transport.ports file for 30s.
* Closes elastic#35456
original-brownbear added a commit that referenced this pull request Nov 15, 2018
* DISCOVERY: 0s Initial State Timeout in Tests

* Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait
for its own transport.ports file for 30s.
* Closes #35456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >test Issues or PRs that are addressing/adding tests v6.6.0 v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants