-
Notifications
You must be signed in to change notification settings - Fork 25.6k
DISCOVERY: 0s Initial State Timeout in Tests #35481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait for its own transport.ports file for 30s. * Closes elastic#35456
|
Pinging @elastic/es-distributed |
DaveCTurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, but I'm not sure about the fix. I think this only affects the rolling-upgrade tests, in which Gradle believes us to have a one-node cluster but the minimum_master_nodes setting indicates otherwise. I think it'd be better to say if (minimumMasterNodes > 1) ...?
I think we should consider, as a followup, moving the writing of the transport ports file earlier in the node startup and getting rid of the initial_state_timeout overrides like this.
Sure :) That works too fixing.
Yes please :) |
|
Fixed :) |
buildSrc/src/main/groovy/org/elasticsearch/gradle/test/ClusterFormationTasks.groovy
Outdated
Show resolved
Hide resolved
DaveCTurner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@DaveCTurner thanks! |
* DISCOVERY: 0s Initial State Timeout in Tests * Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait for its own transport.ports file for 30s. * Closes elastic#35456
* DISCOVERY: 0s Initial State Timeout in Tests * Don't wait for initial state even with a single node, otherwise the loop writing the discovery file causes that single node to wait for its own transport.ports file for 30s. * Closes #35456
unicastTransportUricall waits for that file to come up).unicastTransportUrifield