Skip to content

Conversation

@bleskes
Copy link
Contributor

@bleskes bleskes commented Apr 24, 2018

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757

…art upgrad docs

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.
@colings86 colings86 added >docs General docs changes :Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@ywelsch
Copy link
Contributor

ywelsch commented Apr 24, 2018

why is this PR opened against 6.2 instead of master?

@bleskes
Copy link
Contributor Author

bleskes commented Apr 24, 2018

@ywelsch that's because this is how our "edit this" links on the websites are wired. It has to be that way to avoid confusion when people try to edit what they see. I will future port it once lgtmed.

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (one nit)

--
When all nodes have joined the cluster and recovered their primary shards,
reenable allocation.
reenable allocation by restoring `cluster.routing.allocation.enable` to it's
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's -> its

@bleskes bleskes merged commit f0b8f82 into elastic:6.2 May 1, 2018
@bleskes bleskes deleted the patch-1 branch May 1, 2018 13:20
@bleskes
Copy link
Contributor Author

bleskes commented May 1, 2018

Thanks @ywelsch

bleskes added a commit that referenced this pull request May 1, 2018
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed Indexing/Distributed A catch all label for anything in the Distributed Indexing Area. Please avoid if you can. >docs General docs changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants