-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Remove usage of transient settings to enable allocations in full restart upgrade docs #29670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…art upgrad docs Since we disable allocation using persistent settings, we should be consistent and remove the setting from the persistent storage. Otherwise an accidental restart will leed for shards not being allocated.
|
Pinging @elastic/es-distributed |
|
why is this PR opened against 6.2 instead of master? |
|
@ywelsch that's because this is how our "edit this" links on the websites are wired. It has to be that way to avoid confusion when people try to edit what they see. I will future port it once lgtmed. |
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (one nit)
| -- | ||
| When all nodes have joined the cluster and recovered their primary shards, | ||
| reenable allocation. | ||
| reenable allocation by restoring `cluster.routing.allocation.enable` to it's |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's -> its
|
Thanks @ywelsch |
Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.
Relates to #28757