Skip to content

[DOCS] Use transient setting to reenabled allocation. Closes #27677 #28757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DOCS] Use transient setting to reenabled allocation. Closes #27677 #28757

wants to merge 1 commit into from

Conversation

@debadair
Copy link
Contributor

@debadair debadair commented Feb 21, 2018

Modified the FCR reenable step to use transient per @pickypg and added a reminder about precedence and the need to explicitly reenable allocation after a FCR.

@debadair debadair requested review from pickypg and tsouza February 21, 2018 02:23
pickypg
pickypg approved these changes Feb 21, 2018
View reviewed changes
Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@colings86 colings86 added >docs General docs changes :Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) labels Apr 24, 2018
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 24, 2018

Pinging @elastic/es-distributed

@bleskes
Copy link
Contributor

bleskes commented Apr 24, 2018

This seems to have been incorporated into the docs (though I don't think it's advice :( ).. closing and will open a PR to discuss possible changes.

@colings86 colings86 closed this Apr 24, 2018
@bleskes bleskes mentioned this pull request Apr 24, 2018
Merged
bleskes added a commit to bleskes/elasticsearch that referenced this pull request Apr 24, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
78f401c 
…pgrade docs

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to elastic#28757
@bleskes bleskes mentioned this pull request Apr 24, 2018
Merged
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in full rest…
f0b8f82 
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in full rest…
21d0d76 
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in full rest…
d420300 
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in full rest…
6229c0c 
…art upgrade docs (#29670)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will leed for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
9a89299 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
939a4f5 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
5c6a57a 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
bleskes added a commit that referenced this pull request May 1, 2018
@bleskes
Remove usage of transient settings to enable allocations in rolling u…
f4901b8 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
danielmitterdorfer pushed a commit that referenced this pull request Jan 30, 2019
@bleskes @danielmitterdorfer
Remove usage of transient settings to enable allocations in rolling u…
728013a 
…pgrade docs (#29671)

Since we disable allocation using persistent settings, we should be consistent and remove
the setting from the persistent storage. Otherwise an accidental restart will lead for shards
not being allocated.

Relates to #28757
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pickypg pickypg pickypg approved these changes

@tsouza tsouza Awaiting requested review from tsouza

Assignees

No one assigned

Labels

:Distributed Coordination/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >docs General docs changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@debadair @elasticmachine @bleskes @pickypg @colings86