Require JDK 10 to build Elasticsearch #29174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit bumps the minimum compiler version required to build Elasticsearch from JDK 9 to JDK 10.
jasontedor
added
review
:Delivery/Build
Collaborator
|
Pinging @elastic/es-core-infra |
rjernst
approved these changes
Mar 20, 2018
Member
rjernst
left a comment
rjernst
left a comment
There was a problem hiding this comment.
LGTM, but we need CI updated first.
* master: Fix BWC issue for PreSyncedFlushResponse Remove BytesArray and BytesReference usage from XContentFactory (elastic#29151) Add pluggable XContentBuilder writers and human readable writers (elastic#29120) Add unreleased version 6.2.4 (elastic#29171) Add unreleased version 6.1.5 (elastic#29168) Add a note about using the `retry_failed` flag before accepting data loss (elastic#29160) Fix typo in percolate-query.asciidoc (elastic#29155) Require HTTP::Tiny 0.070 for release notes script
Member
Author
|
@rjernst Yes, I opened an issue with them for that this morning. |
hub-cap
added
:Delivery/Packaging
* master: (40 commits) Do not optimize append-only if seen normal op with higher seqno (elastic#28787) [test] packaging: gradle tasks for groovy tests (elastic#29046) Prune only gc deletes below local checkpoint (elastic#28790) remove testUnassignedShardAndEmptyNodesInRoutingTable elastic#28745: remove extra option in the composite rest tests Fold EngineDiskUtils into Store, for better lock semantics (elastic#29156) Add file permissions checks to precommit task Remove execute mode bit from source files Optimize the composite aggregation for match_all and range queries (elastic#28745) [Docs] Add rank_eval size parameter k (elastic#29218) [DOCS] Remove ignore_z_value parameter link Docs: Update docs/index_.asciidoc (elastic#29172) Docs: Link C++ client lib elasticlient (elastic#28949) [DOCS] Unregister repository instead of deleting it (elastic#29206) Docs: HighLevelRestClient#multiSearch (elastic#29144) Add Z value support to geo_shape Remove type casts in logging in server component (elastic#28807) Change BroadcastResponse from ToXContentFragment to ToXContentObject (elastic#28878) REST : Split `RestUpgradeAction` into two actions (elastic#29124) Add error file docs to important settings ...
dliappis
added a commit
to dliappis/rally
that referenced
this pull request
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
dliappis
added a commit
to dliappis/rally
that referenced
this pull request
Mar 27, 2018
Similar to the work done for elastic#387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes elastic#450 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
jasontedor
added a commit
that referenced
this pull request
Mar 27, 2018
This commit bumps the minimum compiler version required to build Elasticsearch from JDK 9 to JDK 10.
dliappis
added a commit
to elastic/rally
that referenced
this pull request
Mar 28, 2018
Similar to the work done for #387, following the merge of the Elasticsearch PR[1], Rally needs to require java-10 to build Elasticsearch from source. Bump the configuration version to 14 and adjust migration of existing configs to support building with java-10. Also add needed test cases and update docs. Note that building from source with java-10 requires, at minimum, gradle 4.5[2]. This helps us remove a number of additional gradle options that were needed for java-9. So for now, building will fail with gradle <4.5, which will won't be a worry at all once we start using `./gradlew`; this is tracked in issue#412. Closes #450 Relates #451 [1] elastic/elasticsearch#29174 [2] gradle/gradle#3892
martijnvg
added a commit
that referenced
this pull request
Mar 28, 2018
* es/master: (22 commits) Fix building Javadoc JARs on JDK for client JARs (#29274) Require JDK 10 to build Elasticsearch (#29174) Decouple NamedXContentRegistry from ElasticsearchException (#29253) Docs: Update generating test coverage reports (#29255) [TEST] Fix issue with HttpInfo passed invalid parameter Remove all dependencies from XContentBuilder (#29225) Fix sporadic failure in CompositeValuesCollectorQueueTests Propagate ignore_unmapped to inner_hits (#29261) TEST: Increase timeout for testPrimaryReplicaResyncFailed REST client: hosts marked dead for the first time should not be immediately retried (#29230) TEST: Use different translog dir for a new engine Make SearchStats implement Writeable (#29258) [Docs] Spelling and grammar changes to reindex.asciidoc (#29232) Do not optimize append-only if seen normal op with higher seqno (#28787) [test] packaging: gradle tasks for groovy tests (#29046) Prune only gc deletes below local checkpoint (#28790) remove testUnassignedShardAndEmptyNodesInRoutingTable #28745: remove extra option in the composite rest tests Fold EngineDiskUtils into Store, for better lock semantics (#29156) Add file permissions checks to precommit task ...
martijnvg
added a commit
that referenced
this pull request
Mar 28, 2018
* es/6.x: Fix building Javadoc JARs on JDK for client JARs (#29274) Require JDK 10 to build Elasticsearch (#29174) Decouple NamedXContentRegistry from ElasticsearchException (#29253) Docs: Update generating test coverage reports (#29255) [TEST] Fix issue with HttpInfo passed invalid parameter Remove all dependencies from XContentBuilder (#29225) Fix sporadic failure in CompositeValuesCollectorQueueTests Propagate ignore_unmapped to inner_hits (#29261) TEST: Increase timeout for testPrimaryReplicaResyncFailed REST client: hosts marked dead for the first time should not be immediately retried (#29230) Make SearchStats implement Writeable (#29258) [Docs] Spelling and grammar changes to reindex.asciidoc (#29232) [test] packaging: gradle tasks for groovy tests (#29046) remove testUnassignedShardAndEmptyNodesInRoutingTable Add file permissions checks to precommit task Remove execute mode bit from source files #28745: remove 7.x option in the composite rest tests. Optimize the composite aggregation for match_all and range queries (#28745) Clarify deprecation warning for auto_generate_phrase_query (#29204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit bumps the minimum compiler version required to build Elasticsearch from JDK 9 to JDK 10.