spelling and grammatical changes #29232
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
@andrewbanchich these are really a couple of great changes. I left some small suggestions and marked a few spots where I felt there might be something missing. Looking forward to the update.
docs/reference/docs/reindex.asciidoc
Outdated
| `post` type in the `twitter` index and the `_doc` type in the `blog` index. For more | ||
| specific parameters, you can use `query`. | ||
|
|
||
| The Reindex API makes no effort handle ID collisions. For such issues, the target index |
docs/reference/docs/reindex.asciidoc
Outdated
| If you want a particular set of documents from the twitter index you'll | ||
| need to sort. Sorting makes the scroll less efficient but in some contexts | ||
| If you want a particular set of documents from the `twitter` index you'll | ||
| need to `sort`. Sorting makes the scroll less efficient but in some contexts |
There was a problem hiding this comment.
nit: If this is not refering to the verb "sort" but to the dsl command in the following example, I would use "you'll need to use sort".
docs/reference/docs/reindex.asciidoc
Outdated
| need to `sort`. Sorting makes the scroll less efficient but in some contexts | ||
| it's worth it. If possible, prefer a more selective query to `size` and `sort`. | ||
| This will copy 10000 documents from `twitter` into `new_twitter`: | ||
| This will copy 10,000 documents from `twitter` into `new_twitter`: |
There was a problem hiding this comment.
nit: I'd leave this as is, the comma is used in many countries (e.g. in Germany and most of the EU) as the decimal separator, so to me personally this reads more like 10 (with a weird extra zero). The existing version might not be as good to read but is less ambiguous I think.
docs/reference/docs/reindex.asciidoc
Outdated
| // TEST[setup:big_twitter] | ||
|
|
||
| Which you also can verify works with: | ||
| You can also verify works with: |
There was a problem hiding this comment.
"it works" or "this works" maybe?
docs/reference/docs/reindex.asciidoc
Outdated
|
|
||
| You can limit the documents by adding a type to the `source` or by adding a | ||
| query. This will only copy ++tweet++'s made by `kimchy` into `new_twitter`: | ||
| query. This will only copy ++tweet++s made by `kimchy` into `new_twitter`: |
There was a problem hiding this comment.
I wonder if you could close #29231 and use this PR for those changes instead.
There was a problem hiding this comment.
Great, could you also remove the special formatting of "tweet" here as suggested in #29231?
There was a problem hiding this comment.
Forgot about that. Fixed!
Fixes a few other issues
|
@cbuescher All set with these changes! |
removes special formatting of "tweet"
cbuescher
left a comment
cbuescher
left a comment
There was a problem hiding this comment.
@andrewbanchich that for the update, much appreciated. I will kick of a final test run before I merge.
|
@elasticmachine test this please |
* es/master: (22 commits) Fix building Javadoc JARs on JDK for client JARs (#29274) Require JDK 10 to build Elasticsearch (#29174) Decouple NamedXContentRegistry from ElasticsearchException (#29253) Docs: Update generating test coverage reports (#29255) [TEST] Fix issue with HttpInfo passed invalid parameter Remove all dependencies from XContentBuilder (#29225) Fix sporadic failure in CompositeValuesCollectorQueueTests Propagate ignore_unmapped to inner_hits (#29261) TEST: Increase timeout for testPrimaryReplicaResyncFailed REST client: hosts marked dead for the first time should not be immediately retried (#29230) TEST: Use different translog dir for a new engine Make SearchStats implement Writeable (#29258) [Docs] Spelling and grammar changes to reindex.asciidoc (#29232) Do not optimize append-only if seen normal op with higher seqno (#28787) [test] packaging: gradle tasks for groovy tests (#29046) Prune only gc deletes below local checkpoint (#28790) remove testUnassignedShardAndEmptyNodesInRoutingTable #28745: remove extra option in the composite rest tests Fold EngineDiskUtils into Store, for better lock semantics (#29156) Add file permissions checks to precommit task ...
* es/6.x: Fix building Javadoc JARs on JDK for client JARs (#29274) Require JDK 10 to build Elasticsearch (#29174) Decouple NamedXContentRegistry from ElasticsearchException (#29253) Docs: Update generating test coverage reports (#29255) [TEST] Fix issue with HttpInfo passed invalid parameter Remove all dependencies from XContentBuilder (#29225) Fix sporadic failure in CompositeValuesCollectorQueueTests Propagate ignore_unmapped to inner_hits (#29261) TEST: Increase timeout for testPrimaryReplicaResyncFailed REST client: hosts marked dead for the first time should not be immediately retried (#29230) Make SearchStats implement Writeable (#29258) [Docs] Spelling and grammar changes to reindex.asciidoc (#29232) [test] packaging: gradle tasks for groovy tests (#29046) remove testUnassignedShardAndEmptyNodesInRoutingTable Add file permissions checks to precommit task Remove execute mode bit from source files #28745: remove 7.x option in the composite rest tests. Optimize the composite aggregation for match_all and range queries (#28745) Clarify deprecation warning for auto_generate_phrase_query (#29204)
4 participants
fixes spelling and grammatical issues