Add a note about using the retry_failed flag before accepting data loss
#29160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
reviewed
Mar 20, 2018
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
I think it'd be better to move the "Retry failed shards" section up to line 75, and separate it from the dangerous commands with a suitably scary heading (e.g. "Dangerously forcing primary allocation")
DaveCTurner
added
the
:Distributed Coordination/Allocation
Collaborator
|
Pinging @elastic/es-distributed |
Contributor
Author
|
@DaveCTurner I didn't want to break the commands into two sections, but upon further thinking I agree that's the best thing to do. I'll give it a shot. |
Contributor
Author
|
@DaveCTurner care to take another look? |
bleskes
added a commit
that referenced
this pull request
Mar 20, 2018
bleskes
added a commit
that referenced
this pull request
Mar 20, 2018
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 21, 2018
* master: [Docs] Update api.asciidoc (elastic#29166) Docs: Add note about missing mapping for doc values field (elastic#29036) Fix BWC issue for PreSyncedFlushResponse Remove BytesArray and BytesReference usage from XContentFactory (elastic#29151) Add pluggable XContentBuilder writers and human readable writers (elastic#29120) Add unreleased version 6.2.4 (elastic#29171) Add unreleased version 6.1.5 (elastic#29168) Add a note about using the `retry_failed` flag before accepting data loss (elastic#29160) Fix typo in percolate-query.asciidoc (elastic#29155) Require HTTP::Tiny 0.070 for release notes script
martijnvg
added a commit
that referenced
this pull request
Mar 21, 2018
* es/master: (50 commits) Reject updates to the `_default_` mapping. (#29165) Improve similarity docs. (#29089) [Docs] Update api.asciidoc (#29166) Docs: Add note about missing mapping for doc values field (#29036) Fix BWC issue for PreSyncedFlushResponse Remove BytesArray and BytesReference usage from XContentFactory (#29151) Add pluggable XContentBuilder writers and human readable writers (#29120) Add unreleased version 6.2.4 (#29171) Add unreleased version 6.1.5 (#29168) Add a note about using the `retry_failed` flag before accepting data loss (#29160) Fix typo in percolate-query.asciidoc (#29155) Require HTTP::Tiny 0.070 for release notes script Set Java 9 checkstyle to depend on checkstyle conf (#28383) REST high-level client: add clear cache API (#28866) Docs: Add example of resetting index setting (#29048) Plugins: Fix module name conflict check for meta plugins (#29146) Build: Fix meta plugin bundled plugin names (#29147) Build: Simplify rest spec hack configuration (#29149) Build: Fix meta modules to not install as plugin in tests (#29150) Fix javadoc warning in Strings for missing parameter description ...
martijnvg
added a commit
that referenced
this pull request
Mar 21, 2018
* es/6.x: (46 commits) Docs: Add note about missing mapping for doc values field (#29036) [DOCS] Removed 6.1.4, 6.2.2, and 6.2.3 coming tags Remove BytesArray and BytesReference usage from XContentFactory (#29151) Fix BWC issue for PreSyncedFlushResponse Add pluggable XContentBuilder writers and human readable writers (#29120) Add unreleased version 6.2.4 (#29171) Add unreleased version 6.1.5 (#29168) Add a note about using the `retry_failed` flag before accepting data loss (#29160) Fix typo in percolate-query.asciidoc (#29155) Add release notes for 6.1.4 and 6.2.3 Require HTTP::Tiny 0.070 for release notes script REST high-level client: add clear cache API (#28866) Relax remote check for bwc project checkouts (#28666) Set Java 9 checkstyle to depend on checkstyle conf (#28383) Docs: Add example of resetting index setting (#29048) Plugins: Fix module name conflict check for meta plugins (#29146) Build: Fix meta plugin bundled plugin names (#29147) Build: Simplify rest spec hack configuration (#29149) CLI: Close subcommands in MultiCommand (#28954) Build: Fix meta modules to not install as plugin in tests (#29150) ...
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 27, 2018
* master: Fix BWC issue for PreSyncedFlushResponse Remove BytesArray and BytesReference usage from XContentFactory (elastic#29151) Add pluggable XContentBuilder writers and human readable writers (elastic#29120) Add unreleased version 6.2.4 (elastic#29171) Add unreleased version 6.1.5 (elastic#29168) Add a note about using the `retry_failed` flag before accepting data loss (elastic#29160) Fix typo in percolate-query.asciidoc (elastic#29155) Require HTTP::Tiny 0.070 for release notes script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #23199 (comment)