Skip to content

Conversation

@jpountz
Copy link
Contributor

@jpountz jpountz commented Mar 20, 2018

This will reject mapping updates to the _default_ mapping with 7.x indices
and still emit a deprecation warning with 6.x indices.

Relates #15613
Supersedes #28248

This will reject mapping updates to the `_default_` mapping with 7.x indices
and still emit a deprecation warning with 6.x indices.

Relates elastic#15613
Supersedes elastic#28248
@jpountz jpountz added >enhancement >breaking :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0 labels Mar 20, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

Copy link
Contributor

@colings86 colings86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpountz I left a very minor comment but this LGTM with or without my suggestion implemented


==== The `_default_` mapping is disallowed

The `_default_` mapping has been deprecated in 6.0 and is now disallowed in 7.0.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: Instead of disallowed could we say no longer allowed? To me it reads a bit easier

@jpountz jpountz merged commit 8f9d2ee into elastic:master Mar 21, 2018
@jpountz jpountz deleted the enhancement/reject_default_mapping branch March 21, 2018 09:44
martijnvg added a commit that referenced this pull request Mar 21, 2018
* es/master: (50 commits)
  Reject updates to the `_default_` mapping. (#29165)
  Improve similarity docs. (#29089)
  [Docs] Update api.asciidoc (#29166)
  Docs: Add note about missing mapping for doc values field (#29036)
  Fix BWC issue for PreSyncedFlushResponse
  Remove BytesArray and BytesReference usage from XContentFactory (#29151)
  Add pluggable XContentBuilder writers and human readable writers (#29120)
  Add unreleased version 6.2.4 (#29171)
  Add unreleased version 6.1.5 (#29168)
  Add a note about using the `retry_failed` flag before accepting data loss (#29160)
  Fix typo in percolate-query.asciidoc (#29155)
  Require HTTP::Tiny 0.070 for release notes script
  Set Java 9 checkstyle to depend on checkstyle conf (#28383)
  REST high-level client: add clear cache API (#28866)
  Docs: Add example of resetting index setting (#29048)
  Plugins: Fix module name conflict check for meta plugins (#29146)
  Build: Fix meta plugin bundled plugin names (#29147)
  Build: Simplify rest spec hack configuration (#29149)
  Build: Fix meta modules to not install as plugin in tests (#29150)
  Fix javadoc warning in Strings for missing parameter description
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>breaking >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants