-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Update Gradle Testing Docs #28970
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Gradle Testing Docs #28970
Conversation
Attempting to run the REST tests, I noticed the testing instructions in the `TESTING.asciidoc` were outdated, so I fixed the paths. Steps I took to test: * Ran `./gradlew :distribution:packages:rpm:assemble` and make sure RPM is created in `./distribution/packages/rpm/build/distributions/` * Ran testing commands and verified the REST tests ran.
ywelsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jasontedor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nik9000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOOH! A review party!
Attempting to run the REST tests, I noticed the testing instructions in the `TESTING.asciidoc` were outdated, so I fixed the paths. Steps I took to test: * Ran `./gradlew :distribution:packages:rpm:assemble` and make sure RPM is created in `./distribution/packages/rpm/build/distributions/` * Ran testing commands and verified the REST tests ran.
Attempting to run the REST tests, I noticed the testing instructions in the `TESTING.asciidoc` were outdated, so I fixed the paths. Steps I took to test: * Ran `./gradlew :distribution:packages:rpm:assemble` and make sure RPM is created in `./distribution/packages/rpm/build/distributions/` * Ran testing commands and verified the REST tests ran.
* master: (28 commits) Maybe die before failing engine (elastic#28973) Remove special handling for _all in nodes info Remove Booleans use from XContent and ToXContent (elastic#28768) Update Gradle Testing Docs (elastic#28970) Make primary-replica resync failures less lenient (elastic#28534) Remove temporary file 10_basic.yml~ Use different pipeline id in test. (pipelines do not get removed between tests extending from ESIntegTestCase) Use fixture to test the repository-gcs plugin (elastic#28788) Use String.join() to describe a list of tasks (elastic#28941) Fixed incorrect test try-catch statement Plugins: Consolidate plugin and module loading code (elastic#28815) percolator: Take `matchAllDocs` and `verified` of the sub result into account when analyzing a function_score query. Build: Remove rest tests on archive distribution projects (elastic#28952) Remove FastStringReader in favor of vanilla StringReader (elastic#28944) Remove FastCharArrayReader and FastCharArrayWriter (elastic#28951) Continue registering pipelines after one pipeline parse failure. (elastic#28752) Build: Fix ability to ignore when no tests are run (elastic#28930) [rest-api-spec] update doc link for /_rank_eval Switch XContentBuilder from BytesStreamOutput to ByteArrayOutputStream (elastic#28945) Factor UnknownNamedObjectException into its own class (elastic#28931) ...
Attempting to run the REST tests, I noticed the testing instructions
in the
TESTING.asciidocwere outdated, so I fixed the paths.Steps I took to test:
Ran
./gradlew :distribution:packages:rpm:assembleand make sureRPM is created in
./distribution/packages/rpm/build/distributions/Ran testing commands and verified the REST tests ran.