Factor UnknownNamedObjectException into its own class #28931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the inner class `UnknownNamedObjectException` from `NamedXContentRegistry` into a top-level class. This is so that `NamedXContentRegistry` doesn't have to depend on StreamInput and StreamOutput. Relates to elastic#28504
Member
Author
|
/cc @elastic/es-core-infra |
jasontedor
approved these changes
Mar 8, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left two comments; no need for another review after addressing.
| UNKNOWN_NAMED_OBJECT_EXCEPTION(org.elasticsearch.common.xcontent.NamedXContentRegistry.UnknownNamedObjectException.class, | ||
| org.elasticsearch.common.xcontent.NamedXContentRegistry.UnknownNamedObjectException::new, 148, Version.V_5_2_0), | ||
| UNKNOWN_NAMED_OBJECT_EXCEPTION(UnknownNamedObjectException.class, | ||
| UnknownNamedObjectException::new, 148, Version.V_5_2_0), |
Member
There was a problem hiding this comment.
Would you make this consistent with the rest of the code and use the fully-qualified name here (instead of adding an import)?
| private final String name; | ||
|
|
||
| public UnknownNamedObjectException(XContentLocation contentLocation, Class<?> categoryClass, | ||
| String name) { |
Member
There was a problem hiding this comment.
This looks like it will fit on the previous line and remain under 140 columns?
nik9000
approved these changes
Mar 8, 2018
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
I'm fine with the move but I don't think this helps much with decoupling. It still extends from ElasticsearchException.
Member
Author
Yeah, it just makes it easier for me to go programatically through each file and separate them |
Member
Fine by me. |
dakrone
added a commit
that referenced
this pull request
Mar 8, 2018
* Factor UnknownNamedObjectException into its own class This moves the inner class `UnknownNamedObjectException` from `NamedXContentRegistry` into a top-level class. This is so that `NamedXContentRegistry` doesn't have to depend on StreamInput and StreamOutput. Relates to #28504
sebasjm
pushed a commit
to sebasjm/elasticsearch
that referenced
this pull request
Mar 10, 2018
* Factor UnknownNamedObjectException into its own class This moves the inner class `UnknownNamedObjectException` from `NamedXContentRegistry` into a top-level class. This is so that `NamedXContentRegistry` doesn't have to depend on StreamInput and StreamOutput. Relates to elastic#28504
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 12, 2018
* master: (28 commits) Maybe die before failing engine (elastic#28973) Remove special handling for _all in nodes info Remove Booleans use from XContent and ToXContent (elastic#28768) Update Gradle Testing Docs (elastic#28970) Make primary-replica resync failures less lenient (elastic#28534) Remove temporary file 10_basic.yml~ Use different pipeline id in test. (pipelines do not get removed between tests extending from ESIntegTestCase) Use fixture to test the repository-gcs plugin (elastic#28788) Use String.join() to describe a list of tasks (elastic#28941) Fixed incorrect test try-catch statement Plugins: Consolidate plugin and module loading code (elastic#28815) percolator: Take `matchAllDocs` and `verified` of the sub result into account when analyzing a function_score query. Build: Remove rest tests on archive distribution projects (elastic#28952) Remove FastStringReader in favor of vanilla StringReader (elastic#28944) Remove FastCharArrayReader and FastCharArrayWriter (elastic#28951) Continue registering pipelines after one pipeline parse failure. (elastic#28752) Build: Fix ability to ignore when no tests are run (elastic#28930) [rest-api-spec] update doc link for /_rank_eval Switch XContentBuilder from BytesStreamOutput to ByteArrayOutputStream (elastic#28945) Factor UnknownNamedObjectException into its own class (elastic#28931) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the inner class
UnknownNamedObjectExceptionfromNamedXContentRegistryinto a top-level class. This is so thatNamedXContentRegistrydoesn't have to depend on StreamInput and StreamOutput.Relates to #28504