Plugins: Consolidate plugin and module loading code #28815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At one point, modules and plugins were very different. But effectively now they are the same, just from different directories. This commit unifies the loading methods so they are simply two different directories. Note that the main codepath to load plugin bundles had duplication (was not calling getPluginBundles) since previous refactorings to add meta plugins. Note this change also rewords the primary exception message when a plugin descriptor is missing, as the wording asking if the plugin was built before 2.0 isn't really applicable anymore (it is highly unlikely someone tries to install a 1.x plugin on any modern version).
rjernst
added
:Core/Infra/Plugins
Member
Author
|
/cc @elastic/es-core-infra |
jasontedor
approved these changes
Feb 26, 2018
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
Looks good, aside from the currently failing tests (they look like minor failures).
rjernst
added a commit
that referenced
this pull request
Mar 9, 2018
At one point, modules and plugins were very different. But effectively now they are the same, just from different directories. This commit unifies the loading methods so they are simply two different directories. Note that the main codepath to load plugin bundles had duplication (was not calling getPluginBundles) since previous refactorings to add meta plugins. Note this change also rewords the primary exception message when a plugin descriptor is missing, as the wording asking if the plugin was built before 2.0 isn't really applicable anymore (it is highly unlikely someone tries to install a 1.x plugin on any modern version).
sebasjm
pushed a commit
to sebasjm/elasticsearch
that referenced
this pull request
Mar 10, 2018
At one point, modules and plugins were very different. But effectively now they are the same, just from different directories. This commit unifies the loading methods so they are simply two different directories. Note that the main codepath to load plugin bundles had duplication (was not calling getPluginBundles) since previous refactorings to add meta plugins. Note this change also rewords the primary exception message when a plugin descriptor is missing, as the wording asking if the plugin was built before 2.0 isn't really applicable anymore (it is highly unlikely someone tries to install a 1.x plugin on any modern version).
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Mar 12, 2018
* master: (28 commits) Maybe die before failing engine (elastic#28973) Remove special handling for _all in nodes info Remove Booleans use from XContent and ToXContent (elastic#28768) Update Gradle Testing Docs (elastic#28970) Make primary-replica resync failures less lenient (elastic#28534) Remove temporary file 10_basic.yml~ Use different pipeline id in test. (pipelines do not get removed between tests extending from ESIntegTestCase) Use fixture to test the repository-gcs plugin (elastic#28788) Use String.join() to describe a list of tasks (elastic#28941) Fixed incorrect test try-catch statement Plugins: Consolidate plugin and module loading code (elastic#28815) percolator: Take `matchAllDocs` and `verified` of the sub result into account when analyzing a function_score query. Build: Remove rest tests on archive distribution projects (elastic#28952) Remove FastStringReader in favor of vanilla StringReader (elastic#28944) Remove FastCharArrayReader and FastCharArrayWriter (elastic#28951) Continue registering pipelines after one pipeline parse failure. (elastic#28752) Build: Fix ability to ignore when no tests are run (elastic#28930) [rest-api-spec] update doc link for /_rank_eval Switch XContentBuilder from BytesStreamOutput to ByteArrayOutputStream (elastic#28945) Factor UnknownNamedObjectException into its own class (elastic#28931) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point, modules and plugins were very different. But effectively
now they are the same, just from different directories. This commit
unifies the loading methods so they are simply two different
directories. Note that the main codepath to load plugin bundles had
duplication (was not calling getPluginBundles) since previous
refactorings to add meta plugins. Note this change also rewords the
primary exception message when a plugin descriptor is missing, as the
wording asking if the plugin was built before 2.0 isn't really
applicable anymore (it is highly unlikely someone tries to install a 1.x
plugin on any modern version).