Add ranking evaluation API to High Level Rest Client #28357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
review
:Search Relevance/Ranking
cbuescher
commented
Jan 24, 2018
Member
Author
There was a problem hiding this comment.
I opened a separate PR (#28341) to adress this, so depending on which one gets in first this might already be irrelevant.
javanna
approved these changes
Jan 29, 2018
Member
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
I left a couple of questions, LGTM though. Good stuff ;)
Member
There was a problem hiding this comment.
how do we do here with random fields, forward comp etc.?
Member
Author
There was a problem hiding this comment.
I added inserting random fields, which of course exposed some issues. Also fixed those in the next commit.
Member
There was a problem hiding this comment.
same as above, should we test random fields insertion?
Member
Author
There was a problem hiding this comment.
Exactly, the fields are already set as a ctor argument before (L548), so this is redundant.
cbuescher
force-pushed
the
add-hlclient-rankeval
branch
from
1da7dfd to
19a4254
Compare
cbuescher
force-pushed
the
add-hlclient-rankeval
branch
from
603052c to
aaad9a1
Compare
cbuescher
pushed a commit
that referenced
this pull request
Jan 30, 2018
This change adds support for the new ranking evaluation API to the High Level Rest Client. This mostly means adding support for parsing the various response objects back from the REST representation. It includes one change to the response syntax where previously we didn't print the type of the metric details section but we now need it to pick the right parser to parse this section back. Closes #28198
jpountz
removed
the
:Search Relevance/Ranking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the new ranking evaluation API to the High Level Rest Client.
This mostly means adding support for parsing the various response objects back from the
REST representation. It includes one change to the response syntax where previously we didn't
print the type of the metric details section but we now need it to pick the right parser to
parse this section back. Since this API is marked as experimental this should be okay to change
on a minor version.