Test that rank_eval request parsing is not lenient #28516
Conversation
The parsing of the ranking evaluation request and its subcomponents should detect unknown fields and throw parsing errors. This currently isn't testing so this change adds those tests and changes the parser behaviour in cases where it is needed.
cbuescher
force-pushed
the
test-rankeval-parsing-not-lenient
branch
from
7446959 to
93c56c5
Compare
javanna
left a comment
javanna
left a comment
There was a problem hiding this comment.
left a question, LGTM otherwise
| } | ||
| } | ||
|
|
||
| public void testXContentParsingNotLenient() throws IOException { |
There was a problem hiding this comment.
is this testing that parsing is or is not lenient? I can't get that from the name ;) Is this part of a request or response?
There was a problem hiding this comment.
This is testing that adding random fields somewhere in the xContent throws an error. So its testing that parsing is not lenient. All these are part of the request, so I think thats the behaviour we want there, whereas we want to be lenient on the response side. I can rename all these test methods to e.g. testRequestParsingIsNotLenient, maybe add a short comment as well. Would that be better?
There was a problem hiding this comment.
Adding the is verb is good enough on my end, thanks.
|
@javanna thanks for the review, I pushed an update and will merge once CI is green |
Parsing of a ranking evaluation request and its subcomponents should throw parsing errors on unknown fields. This change adds tests for this and changes the parser behaviour in cases where it is needed.
4 participants
The parsing of the ranking evaluation request and its subcomponents should
detect unknown fields and throw parsing errors. This currently isn't testing so
this change adds those tests and changes the parser behaviour in cases where it
is needed.