Try to convince the JVM not to lose stacktraces #24426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds `-XX:-OmitStackTraceInFastThrow` to the JVM arguments which *should* prevent the JVM from omitting stack traces on common exception sites. Even though these sites are common, we'd still like the exceptions to debug them. This also adds the flag when running tests and adapts some tests that had workarounds for the absense of the flag. Closes elastic#24376
jasontedor
approved these changes
May 2, 2017
Member
jasontedor
left a comment
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment about multi-line comments but I'm good either way.
| IndexOutOfBoundsException e = expectScriptThrows(IndexOutOfBoundsException.class, () -> | ||
| exec(script, singletonMap("val", val), true)); | ||
| try { | ||
| /* If this fails you *might* be missing -XX:-OmitStackTraceInFastThrow in the test jvm |
Member
There was a problem hiding this comment.
Sorry to nit, I think that this is cleaner for multi-line comments:
/*
* Text goes here.
* A blank line above and below makes it clean.
*/
Member
Author
There was a problem hiding this comment.
I like the stately form of multiline comments for javadocs and really long comments that have to stand out but I tend to prefer this one for single line comments that happen to be long enough that they end up on multiple lines. Clear as mud?
| /* If this fails you *might* be missing -XX:-OmitStackTraceInFastThrow in the test jvm | ||
| * In Eclipse you can add this by default by going to Preference->Java->Installed JREs, | ||
| * clicking on the default JRE, clicking edit, and adding the flag to the | ||
| * "Default VM Arguments". */ |
Member
There was a problem hiding this comment.
A blank line above and below. 😄
Member
Author
|
Thanks for reviewing @jasontedor! Merged. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 2, 2017
* master: (27 commits) Check index sorting with no replica since we cannot ensure that the replica index is ready when forceMerge is called. Closes elastic#24416 Docs: correct indentation on callout Build that java api docs from a test (elastic#24354) Move RemoteClusterService into TransportService (elastic#24424) Fix license header in WildflyIT.java Try not to lose stacktraces (elastic#24426) [DOCS] Update XPack Reference URL for 5.4 (elastic#24425) Painless: Add tests to check for existence and correct detection of the special Java 9 optimizations: Indified String concat and MethodHandles#ArrayLengthHelper() (elastic#24405) Extract a common base class to allow services to listen to remote cluster config updates (elastic#24367) Adds check to snapshot repository incompatible-snapshots blob to delete a pre-existing one before attempting to overwrite it. Added docs for batched_reduce_size Fixes checkstyle errors Allow scripted metric agg to access `_score` (elastic#24295) [Test] Add unit tests for HDR/TDigest PercentilesAggregators (elastic#24245) Fix FieldCaps documentation Upgrade to JUnit 4.12 (elastic#23877) Set available processors for Netty Painless: Fix method references to ctor with the new LambdaBootstrap and cleanup code (elastic#24406) Doc test: use propery regex for file size [DOCS] Tweak doc test to sync_flush ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
-XX:-OmitStackTraceInFastThrowto the JVM argumentswhich should prevent the JVM from omitting stack traces on
common exception sites. Even though these sites are common, we'd
still like the exceptions to debug them.
This also adds the flag when running tests and adapts some tests
that had workarounds for the absense of the flag.
Closes #24376