Fix JVM test argline #24448
Merged
Fix JVM test argline #24448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The argline was being overridden by '-XX:-OmitStackTraceInFastThrow' which led to test failures that were expecting the JVM to be in a certain state based on the value of tests.jvm.argline but they were not since these arguments were never passed to the JVM. Additionally, we need to respect the provided JVM argline if it is already provided with a flag for OmitStackTraceInFastThrow. This commit fixes this by only setting OmitStackTraceInFastThrow if it is not already set.
jasontedor
added
:Delivery/Build
Member
|
Lgtm. Sorry I didn't catch that.
…On Tue, May 2, 2017, 7:53 PM Jason Tedor ***@***.***> wrote:
@jasontedor <https://github.com/jasontedor> requested your review on:
elastic/elasticsearch#24448
<#24448> Fix JVM test
argline.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#24448 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANLol-M8l1W3NsBZRkGrlnvjoZAsbLyks5r18HpgaJpZM4NO0u8>
.
|
Member
Author
|
Thanks @nik9000. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 3, 2017
* master: Show JVM arguments Log JVM arguments on startup Fix JVM test argline (elastic#24448)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argline was being overridden by '-XX:-OmitStackTraceInFastThrow' which led to test failures that were expecting the JVM to be in a certain state based on the value of tests.jvm.argline but they were not since these arguments were never passed to the JVM. Additionally, we need to respect the provided JVM argline if it is already provided with a flag for OmitStackTraceInFastThrow. This commit fixes this by only setting OmitStackTraceInFastThrow if it is not already set.
Relates #24426