painless: Add tests for Java 9 features #24405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Java 9 optimizations: Indified String concat and MethodHandles#ArrayLengthHelper()
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
uschindler
changed the title
Contributor
|
@elasticmachine please test this |
jdconrad
added
:Plugin Lang Painless
v6.0.0-alpha1
v5.5.0
>test
Contributor
|
Build failure looks unrelated. I'll test this locally. |
Contributor
Author
|
Seems to be fine now! |
jdconrad
pushed a commit
that referenced
this pull request
May 2, 2017
…he special Java 9 optimizations: Indified String concat and MethodHandles#ArrayLengthHelper() (#24405)
Contributor
|
@uschindler Thanks for adding these tests! I committed this to master and 5.5. |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
May 2, 2017
* master: (27 commits) Check index sorting with no replica since we cannot ensure that the replica index is ready when forceMerge is called. Closes elastic#24416 Docs: correct indentation on callout Build that java api docs from a test (elastic#24354) Move RemoteClusterService into TransportService (elastic#24424) Fix license header in WildflyIT.java Try not to lose stacktraces (elastic#24426) [DOCS] Update XPack Reference URL for 5.4 (elastic#24425) Painless: Add tests to check for existence and correct detection of the special Java 9 optimizations: Indified String concat and MethodHandles#ArrayLengthHelper() (elastic#24405) Extract a common base class to allow services to listen to remote cluster config updates (elastic#24367) Adds check to snapshot repository incompatible-snapshots blob to delete a pre-existing one before attempting to overwrite it. Added docs for batched_reduce_size Fixes checkstyle errors Allow scripted metric agg to access `_score` (elastic#24295) [Test] Add unit tests for HDR/TDigest PercentilesAggregators (elastic#24245) Fix FieldCaps documentation Upgrade to JUnit 4.12 (elastic#23877) Set available processors for Netty Painless: Fix method references to ctor with the new LambdaBootstrap and cleanup code (elastic#24406) Doc test: use propery regex for file size [DOCS] Tweak doc test to sync_flush ...
clintongormley
added
:Core/Infra/Scripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that Java 9 is stable and method signatures should no longer change, we should add tests to check for existence and correct detection of the special Java 9 optimizations in painless:
INVOKEDYNAMIC.MethodHandles#arrayLength()should be used. This makes the static constant inDefpkg private and adds a test for non-nullness on Java 9This PR should not to test Java 9 compatibility at runtime (we always fallback to Java 8 behaviour if something breaks), it is intended to break the build instead if we are on Java 9 and painless does not use the better features. This may happen if somebody breaks the reflective lookups.