Fix: don't check logging path if logging disabled #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue where the testing of a connection or saving of the DSN failed when the given logging path was invalid (incorrect or directory missing), even when logging was disabled. The fix is to simply skip path validation if logging is disabled. The commit also changes the tab index of the components of each tab page, so that tab cycling follows the visual order of the elements.
bpintea
added a commit
that referenced
this pull request
Oct 2, 2019
This commit fixes an issue where the testing of a connection or saving of the DSN failed when the given logging path was invalid (incorrect or directory missing), even when logging was disabled. The fix is to simply skip path validation if logging is disabled. The commit also changes the tab index of the components of each tab page, so that tab cycling follows the visual order of the elements. (cherry picked from commit a6a9641)
bpintea
added a commit
that referenced
this pull request
Dec 4, 2019
This commit fixes an issue where the testing of a connection or saving of the DSN failed when the given logging path was invalid (incorrect or directory missing), even when logging was disabled. The fix is to simply skip path validation if logging is disabled. The commit also changes the tab index of the components of each tab page, so that tab cycling follows the visual order of the elements. (cherry picked from commit a6a9641) Cherry-pick conflicts: - dsneditor/EsOdbcDsnEditor/DSNEditorForm.Designer.cs resolved by keeping branch version (tab index fix not applied).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the testing of a connection or saving
of the DSN failed when the given logging path was invalid (incorrect or
directory missing), even when logging was disabled.
The fix is to simply skip path validation if logging is disabled.
The PR also changes the tab index of the components of each tab
page, so that tab cycling follows the visual order of the elements.