Skip to content

Commit 5c5ca63

Browse files
committed
fix: don't check logging path if logging disabled (#186)
This commit fixes an issue where the testing of a connection or saving of the DSN failed when the given logging path was invalid (incorrect or directory missing), even when logging was disabled. The fix is to simply skip path validation if logging is disabled. The commit also changes the tab index of the components of each tab page, so that tab cycling follows the visual order of the elements. (cherry picked from commit a6a9641) Cherry-pick conflicts: - dsneditor/EsOdbcDsnEditor/DSNEditorForm.Designer.cs resolved by keeping branch version (tab index fix not applied).
1 parent 69243d4 commit 5c5ca63

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

dsneditor/EsOdbcDsnEditor/DSNEditorForm.Designer.cs

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dsneditor/EsOdbcDsnEditor/DSNEditorForm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ private void LogDirectoryPathButton_Click(object sender, EventArgs e)
281281

282282
private bool ValidateLogFolderPath(string path)
283283
{
284-
if (string.IsNullOrEmpty(path) || Directory.Exists(path)) {
284+
if (!checkLoggingEnabled.Checked || string.IsNullOrEmpty(path) || Directory.Exists(path)) {
285285
return true;
286286
}
287287

0 commit comments

Comments
 (0)