Skip to content

Commit c54729c

Browse files
committed
fix: don't check logging path if logging disabled (#186)
This commit fixes an issue where the testing of a connection or saving of the DSN failed when the given logging path was invalid (incorrect or directory missing), even when logging was disabled. The fix is to simply skip path validation if logging is disabled. The commit also changes the tab index of the components of each tab page, so that tab cycling follows the visual order of the elements. (cherry picked from commit a6a9641)
1 parent ea897af commit c54729c

File tree

2 files changed

+108
-108
lines changed

2 files changed

+108
-108
lines changed

dsneditor/EsOdbcDsnEditor/DSNEditorForm.Designer.cs

Lines changed: 107 additions & 107 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dsneditor/EsOdbcDsnEditor/DSNEditorForm.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -322,7 +322,7 @@ private void LogDirectoryPathButton_Click(object sender, EventArgs e)
322322

323323
private bool ValidateLogFolderPath(string path)
324324
{
325-
if (string.IsNullOrEmpty(path) || Directory.Exists(path)) {
325+
if (!checkLoggingEnabled.Checked || string.IsNullOrEmpty(path) || Directory.Exists(path)) {
326326
return true;
327327
}
328328

0 commit comments

Comments
 (0)