Effectively remove replaced MonitorAwareRectangle/MonitorAwarePoint #2349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MonitorAwareRectangle/MonitorAwarePoint classes have been replaced by Rectangle.WithMonitor and Point.WithMonitor. They have been marked as deprecated but not removed because of issues with API tooling, however they were marked as non-API so they may be removed without any deprecation period. This change effectively removes the classes, only keeping package-internal stubs of them as otherwise API tooling currently fails.
HeikoKlare
force-pushed
the
monitor-aware-classes-cleanup
branch
from
24c6902 to
5c09456
Compare
fedejeanne
approved these changes
Jul 30, 2025
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Aug 1, 2025
The MonitorAwareRectangle and MonitorAwarePoint classes have been made package-private by SWT[1]. Because Draw2D re-exports SWT, this is considered a breakage in API, which would require a major version increment. This change suppresses those errors, as they are not relevant for Draw2D. [1] eclipse-platform/eclipse.platform.swt#2349
ptziegler
added a commit
to eclipse-gef/gef-classic
that referenced
this pull request
Aug 1, 2025
The MonitorAwareRectangle and MonitorAwarePoint classes have been made package-private by SWT[1]. Because Draw2D re-exports SWT, this is considered a breakage in API, which would require a major version increment. This change suppresses those errors, as they are not relevant for Draw2D. [1] eclipse-platform/eclipse.platform.swt#2349
ptziegler
added a commit
to ptziegler/gef-classic
that referenced
this pull request
Aug 7, 2025
This is a follow-up to 50e27e3, this time for the Zest plug-in. Because it also re-exports the SWT bundle, it is also affected by the removal of the "MonitorAware" SWT classes [1]. This change suppresses those errors, as they are not relevant for Zest. [1] eclipse-platform/eclipse.platform.swt#2349
ptziegler
added a commit
to eclipse-gef/gef-classic
that referenced
this pull request
Aug 7, 2025
This is a follow-up to 50e27e3, this time for the Zest plug-in. Because it also re-exports the SWT bundle, it is also affected by the removal of the "MonitorAware" SWT classes [1]. This change suppresses those errors, as they are not relevant for Zest. [1] eclipse-platform/eclipse.platform.swt#2349
HannesWell
added a commit
that referenced
this pull request
Aug 30, 2025
They remained as stubs to work around API-tools problems: - #2349
HannesWell
added a commit
that referenced
this pull request
Aug 31, 2025
They remained as stubs to work around API-tools problems: - #2349
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MonitorAwareRectangle/MonitorAwarePoint classes have been replaced by Rectangle.WithMonitor and Point.WithMonitor. They have been marked as deprecated but not removed because of issues with API tooling, however they were marked as non-API so they may be removed without any deprecation period.
This change effectively removes the classes, only keeping package-internal stubs of them as otherwise API tooling currently fails.
This is not the cleanest solution as it is driven by tooling limitations, but I don't think we should unnecessarily keep those classes and I am currently stuck in debugging the tooling issue:
Since API tooling treats this change as a breaking API change despite the
@noreferenceJavadoc tag, according API filters are required. This also means that any dependent bundle that reexports SWT and uses API tooling (such asorg.eclipse.jfaceandorg.eclipse.ui) need to be extended with API filters as well if we merge this: