Add API filters for removal of @noreference SWT classes #3136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The classes MonitorAwarePoint and MonitorAwareRectangle have been removed from SWT. They were public inside an API package but marked as `@noreference` as they are not intended to be used as part of an API, which is why API tooling considers there removal a breaking API change. The bundles org.eclipse.ui and org.eclipse.jface reexport SWT packages, which is why API tooling also considers the removal as breaking API change of those bundles. This change adds according API filters.
Contributor
Test Results 2 778 files + 2 778 2 778 suites +2 778 1h 32m 23s ⏱️ + 1h 32m 23s For more details on these failures, see this check. Results for commit 91a9c8c. ± Comparison against base commit 62f9b98. |
Member
|
The failing test is unrelated (#751) and the failing checks about unnecessary filters are expected since the filters only become necessary after merging eclipse-platform/eclipse.platform.swt#2349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The classes MonitorAwarePoint and MonitorAwareRectangle have been removed from SWT. They were public inside an API package but marked as
@noreferenceas they are not intended to be used as part of an API, which is why API tooling considers there removal a breaking API change. The bundles org.eclipse.ui and org.eclipse.jface reexport SWT packages, which is why API tooling also considers the removal as breaking API change of those bundles. This change adds according API filters.Belongs to: