-
Notifications
You must be signed in to change notification settings - Fork 185
Reintroduce OfFloat (internal) classes #62 #2269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reintroduce OfFloat (internal) classes #62 #2269
Conversation
67ca846 to
a68e885
Compare
b5a083e to
4681406
Compare
|
Does anyone have a clue about how to get rid of these kind of errors? |
@laeubi : something in tycho? |
4681406 to
97ef20d
Compare
|
I documented it in Tycho, I hope it's the right place: eclipse-tycho/tycho#5148 Any help with this would be highly appreciated since I would like to merge this PR for M1 to let the community test it too. Thank you in advance! |
ec3cbf0 to
10ecf98
Compare
b0b572d to
7793c8d
Compare
Deprecate MonitorAwarePoint and MonitorAwareRectangle for removal
3056de4 to
12312f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason why this PR marked the MonitorAwarePoint and MonitorAwareRectangle as deprecated instead of removing it like in the original PR #2200?
|
Because they caused check failures (eclipse-tycho/tycho#5148). |
Okay that was not clear to me. The original PR particularly lacked proper API filters for the removed classes, but then it seems as if Tycho is not able to deal with the removal even in case proper filters are added. |
|
Created a PR to effectively remove those classes without running into the tooling issue: |
I think this is a different PR #2349 |
|
Indeed, thank you! It's about: |
Reverts #2264 and also adds the appropriate API filters as per #2200 (comment).