Skip to content

Conversation

@fedejeanne
Copy link
Member

Reverts #2264 and also adds the appropriate API filters as per #2200 (comment).

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2025

Test Results

   545 files  + 6     545 suites  +6   28m 53s ⏱️ - 2m 29s
 4 405 tests +39   4 387 ✅ +62   18 💤 +3  0 ❌  - 7 
16 741 runs  +45  16 599 ✅ +66  142 💤 +5  0 ❌  - 7 

Results for commit 12312f9. ± Comparison against base commit 8a8c67d.

♻️ This comment has been updated with latest results.

@fedejeanne fedejeanne force-pushed the reintroduce_float_precision_in_dpiutil branch from 67ca846 to a68e885 Compare June 26, 2025 13:02
@fedejeanne fedejeanne marked this pull request as ready for review June 26, 2025 13:05
@fedejeanne fedejeanne force-pushed the reintroduce_float_precision_in_dpiutil branch 2 times, most recently from b5a083e to 4681406 Compare June 26, 2025 14:21
@fedejeanne
Copy link
Member Author

Does anyone have a clue about how to get rid of these kind of errors?

00:05:53.938  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:5.0.0-SNAPSHOT:verify (verify) on project org.eclipse.swt.gtk.linux.ppc64le: Execute ApiApplication failed: InvocationTargetException: Cannot invoke "org.eclipse.pde.api.tools.internal.provisional.model.IApiComponent.getSymbolicName()" because "component" is null -> [Help 1]

@iloveeclipse / @akurtakov ?

@iloveeclipse
Copy link
Member

Does anyone have a clue about how to get rid of these kind of errors?

00:05:53.938  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-apitools-plugin:5.0.0-SNAPSHOT:verify (verify) on project org.eclipse.swt.gtk.linux.ppc64le: Execute ApiApplication failed: InvocationTargetException: Cannot invoke "org.eclipse.pde.api.tools.internal.provisional.model.IApiComponent.getSymbolicName()" because "component" is null -> [Help 1]

@iloveeclipse / @akurtakov ?

@laeubi : something in tycho?

@fedejeanne
Copy link
Member Author

I documented it in Tycho, I hope it's the right place: eclipse-tycho/tycho#5148

Any help with this would be highly appreciated since I would like to merge this PR for M1 to let the community test it too.

Thank you in advance!

@fedejeanne fedejeanne force-pushed the reintroduce_float_precision_in_dpiutil branch 9 times, most recently from ec3cbf0 to 10ecf98 Compare June 27, 2025 12:11
@amartya4256 amartya4256 force-pushed the reintroduce_float_precision_in_dpiutil branch 3 times, most recently from b0b572d to 7793c8d Compare June 27, 2025 13:16
Deprecate MonitorAwarePoint and MonitorAwareRectangle for removal
@fedejeanne fedejeanne force-pushed the reintroduce_float_precision_in_dpiutil branch from 3056de4 to 12312f9 Compare June 30, 2025 08:43
@fedejeanne fedejeanne merged commit e06a5ec into eclipse-platform:master Jun 30, 2025
17 checks passed
@fedejeanne fedejeanne deleted the reintroduce_float_precision_in_dpiutil branch June 30, 2025 09:37
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason why this PR marked the MonitorAwarePoint and MonitorAwareRectangle as deprecated instead of removing it like in the original PR #2200?

@fedejeanne
Copy link
Member Author

Because they caused check failures (eclipse-tycho/tycho#5148).

@HeikoKlare
Copy link
Contributor

Because they caused check failures (eclipse-tycho/tycho#5148).

Okay that was not clear to me. The original PR particularly lacked proper API filters for the removed classes, but then it seems as if Tycho is not able to deal with the removal even in case proper filters are added.

@HeikoKlare
Copy link
Contributor

Created a PR to effectively remove those classes without running into the tooling issue:

@arunjose696
Copy link
Contributor

Created a PR to effectively remove those classes without running into the tooling issue:

I think this is a different PR #2349

@HeikoKlare
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reduce scaling error when DPIUtil#scaleDown -> DPIUtil#scaleUp is used

4 participants