Skip to content

Conversation

@akurtakov
Copy link
Member

Change all implementations to not check it but act assume it is always true. This was the case anyway as Device.init explicitly set it that way.

Change all implementations to not check it but act assume it is always
true. This was the case anyway as Device.init explicitly set it that
way.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 17, 2025

Test Results

   431 files  +   431     431 suites  +431   17m 55s ⏱️ + 17m 55s
 4 144 tests + 4 144   4 127 ✅ + 4 127   9 💤 + 9  8 ❌ +8 
12 361 runs  +12 361  12 302 ✅ +12 302  51 💤 +51  8 ❌ +8 

For more details on these failures, see this check.

Results for commit bfe6f51. ± Comparison against base commit 9e57eae.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member Author

@akurtakov
Copy link
Member Author

Failing windows tests are unrelated to gtk change. Merging.

@akurtakov akurtakov merged commit 111b874 into eclipse-platform:master Apr 17, 2025
15 of 17 checks passed
@HeikoKlare
Copy link
Contributor

Failing windows tests are unrelated to gtk change. Merging.

@akurtakov are you sure? I think this actually introduced the Windows test failures. See also #2031 (comment)

I will propose a fix.

@akurtakov
Copy link
Member Author

@HeikoKlare Sorry my fault! Instability of infrastructure and tests lately made me sloppy.

@HeikoKlare
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants