[GTK][HiDpi] Code cleanup for removal of non-cairo scale path #1304

deepika-u · 2024-06-26T05:32:19Z

github-actions · 2024-06-26T05:39:51Z

Test Results

483 files - 3 483 suites - 3 10m 16s ⏱️ + 1m 39s
4 289 tests - 19 4 271 ✅ - 24 12 💤 - 1 0 ❌ ±0 6 🔥 +6
16 376 runs - 37 16 264 ✅ - 41 106 💤 - 2 0 ❌ ±0 6 🔥 +6

For more details on these errors, see this check.

Results for commit d55aaca. ± Comparison against base commit cec96e9.

This pull request removes 19 tests.

org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_emptyString
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letterA
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16LE_null
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_letter
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

deepika-u · 2024-07-10T13:56:01Z

@SyntevoAlex @akurtakov @merks @sravanlakkimsetti
Can you review this please.

SyntevoAlex · 2024-07-12T09:26:25Z

Sorry, I don't think I can find time to review.

deepika-u · 2024-08-09T11:10:16Z

@akurtakov @iloveeclipse
These are the changes done as per @sravanlakkimsetti's suggestions, so can one of you review the changes please.

deepika-u · 2024-09-16T07:27:52Z

@akurtakov @iloveeclipse : Can you review this pr please?

akurtakov · 2024-09-17T14:35:53Z

@deepika-u It's not even compiling as can be seen in the logs:

17:31:20  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.swt.gtk.linux.x86_64: Compilation failure: Compilation failure: 

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[673] 

17:31:20  [ERROR] 	height += getSpacingInPixels();

17:31:20  [ERROR] 	          ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[704] 

17:31:20  [ERROR] 	int yExtent = extent ? getSpacingInPixels() : 0;

17:31:20  [ERROR] 	                       ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] 4 problems (2 errors, 2 warnings)

deepika-u · 2024-09-19T13:38:34Z

@deepika-u It's not even compiling as can be seen in the logs:

17:31:20  [ERROR] Failed to execute goal org.eclipse.tycho:tycho-compiler-plugin:4.0.8:compile (default-compile) on project org.eclipse.swt.gtk.linux.x86_64: Compilation failure: Compilation failure: 

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[673] 

17:31:20  [ERROR] 	height += getSpacingInPixels();

17:31:20  [ERROR] 	          ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1304/eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/gtk/org/eclipse/swt/graphics/TextLayout.java:[704] 

17:31:20  [ERROR] 	int yExtent = extent ? getSpacingInPixels() : 0;

17:31:20  [ERROR] 	                       ^^^^^^^^^^^^^^^^^^

17:31:20  [ERROR] The method getSpacingInPixels() is undefined for the type TextLayout

17:31:20  [ERROR] 4 problems (2 errors, 2 warnings)

Thanks alot for reviewing this pr. I did the needed changes to TextLayout.java and those 2 errors are gone. Sorry it was a miss from my side.

But now seeing error "The method org.eclipse.swt.graphics.Image.getBoundsInPixels() has been removed". For this if i change the version from 3.128.0.qualifier to 4.0.0, this error is gone. Should i be doing this change also? Do you also see this error with respect to Image.java and MANIFEST.MF files?

akurtakov · 2024-09-19T15:47:09Z

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

deepika-u · 2024-09-20T12:58:52Z

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

@akurtakov: Reverted the changes of Image.java, now when pr is applied i am not finding any errors. Can you please review now? Thanks alot in advance.

akurtakov · 2024-09-20T13:02:51Z

@deepika-u You can not delete API. Even if it's deprecated it is not marked forRemoval and it has to stay 2 years after there is release with it marked that way. Bumping major version for that is also a no-go.

@akurtakov: Reverted the changes of Image.java, now when pr is applied i am not finding any errors. Can you please review now? Thanks alot in advance.

Before asking me for review again please look at the build output . Automated build and tests are there so contributors see when things don't compile (previous case) or when tests fail(https://ci.eclipse.org/releng/job/eclipse.platform.swt/job/PR-1304/18/) like now. Please make sure that you have checked all fails and have a clean build before asking explicitly.

deepika-u · 2024-09-23T06:12:24Z

Please make sure that you have checked all fails and have a clean build before asking explicitly.

Thanks for letting me know on another check(which i didnt knew), i shall check on them.

Fixes eclipse-platform#1300

HeikoKlare · 2025-03-12T09:19:09Z

@deepika-u do you plan to finalize this work? Seeing those implementations simplified would still be nice. Maybe it would be possible to split this work up into multiple smaller commits/PRs, so that they can be reviewed more easily.

deepika-u · 2025-03-12T10:14:33Z

@deepika-u do you plan to finalize this work? Seeing those implementations simplified would still be nice. Maybe it would be possible to split this work up into multiple smaller commits/PRs, so that they can be reviewed more easily.

Sure will cross check on it and update you again.

akurtakov · 2025-04-17T05:57:20Z

Do you plan to fix that in next couple of weeks? I would like to see this in June release but it would better be in for M2 in case smth was mixed.

akurtakov · 2025-04-17T06:13:06Z

Actually, I decided to split a bit and plan to land it in pieces. First one be #2030

akurtakov · 2025-05-02T05:27:09Z

Closing as this one went in "mostly" by other PRs. Please create smaller and thus easier to review PRs if you would like to clean up more.

deepika-u force-pushed the 1300_Code_cleanup branch from ba087cb to 1a73f3b Compare June 26, 2024 14:18

deepika-u force-pushed the 1300_Code_cleanup branch 4 times, most recently from b48f0d1 to 52ca34f Compare July 10, 2024 13:36

deepika-u marked this pull request as ready for review July 10, 2024 13:55

deepika-u requested a review from sravanlakkimsetti as a code owner July 10, 2024 13:55

deepika-u force-pushed the 1300_Code_cleanup branch from 34598fc to c8d4aa9 Compare July 15, 2024 07:58

deepika-u force-pushed the 1300_Code_cleanup branch 2 times, most recently from f73d855 to f8c23a3 Compare August 13, 2024 14:15

deepika-u force-pushed the 1300_Code_cleanup branch from f8c23a3 to 5734db2 Compare August 20, 2024 10:40

deepika-u force-pushed the 1300_Code_cleanup branch from 5734db2 to 21e5ae6 Compare September 16, 2024 07:26

akurtakov force-pushed the 1300_Code_cleanup branch from 21e5ae6 to 8a7ad77 Compare September 17, 2024 14:28

deepika-u force-pushed the 1300_Code_cleanup branch 2 times, most recently from bb37696 to 7aa653d Compare September 19, 2024 13:27

deepika-u force-pushed the 1300_Code_cleanup branch from 7aa653d to ff050b1 Compare September 20, 2024 12:46

deepika-u force-pushed the 1300_Code_cleanup branch from ff050b1 to e7f4d5d Compare December 2, 2024 10:07

deepika-u force-pushed the 1300_Code_cleanup branch from e7f4d5d to 51da914 Compare December 31, 2024 06:05

deepika-u force-pushed the 1300_Code_cleanup branch from 51da914 to e4a4f35 Compare January 13, 2025 14:07

deepika-u force-pushed the 1300_Code_cleanup branch from e4a4f35 to cf3d975 Compare January 13, 2025 14:09

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path.

d55aaca

Fixes eclipse-platform#1300

deepika-u force-pushed the 1300_Code_cleanup branch from cf3d975 to d55aaca Compare January 13, 2025 14:10

akurtakov closed this May 2, 2025

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path #1304

[GTK][HiDpi] Code cleanup for removal of non-cairo scale path #1304

Uh oh!

Conversation

deepika-u commented Jun 26, 2024

Uh oh!

github-actions bot commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

deepika-u commented Jul 10, 2024

Uh oh!

SyntevoAlex commented Jul 12, 2024

Uh oh!

deepika-u commented Aug 9, 2024

Uh oh!

deepika-u commented Sep 16, 2024

Uh oh!

akurtakov commented Sep 17, 2024

Uh oh!

deepika-u commented Sep 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akurtakov commented Sep 19, 2024

Uh oh!

deepika-u commented Sep 20, 2024

Uh oh!

akurtakov commented Sep 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

deepika-u commented Sep 23, 2024

Uh oh!

HeikoKlare commented Mar 12, 2025

Uh oh!

deepika-u commented Mar 12, 2025

Uh oh!

akurtakov commented Apr 17, 2025

Uh oh!

akurtakov commented Apr 17, 2025

Uh oh!

akurtakov commented May 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Jun 26, 2024 •

edited

Loading

deepika-u commented Sep 19, 2024 •

edited

Loading

akurtakov commented Sep 20, 2024 •

edited

Loading