Enable publishing in VMR #4215
Enable publishing in VMR #4215
Conversation
NikolaMilosavljevic
requested review from
a team,
RussKie,
ViktorHofer and
mmitche
eng/Publishing.props
Outdated
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <_InstallersToPublish Remove="@(_InstallersToPublish)" /> |
There was a problem hiding this comment.
WindowsDesktop may be special here. I would find out how they are publishing their assets right now.
There was a problem hiding this comment.
It seems that they're using https://github.com/dotnet/windowsdesktop/blob/main/src/publish/prepare-artifacts.proj for publishing.
There was a problem hiding this comment.
Ideally this change would replace https://github.com/dotnet/windowsdesktop/blob/main/src/publish/prepare-artifacts.proj but that might need a bit more work.
Otherwise we would still publish differently. This applies to windowsdesktop and runtime. Both use prepare-artifacts.proj.
There was a problem hiding this comment.
@NikolaMilosavljevic I simplified this code a bit. I hope you don't mind. Testing it locally.
| <ItemsToPushToBlobFeed Include="@(InstallerToPublish)" | ||
| IsShipping="true" | ||
| ManifestArtifactData="DotNetReleaseShipping=true" | ||
| PublishFlatContainer="true" |
There was a problem hiding this comment.
@mmitche any idea why this metadata is set? Just double checking if this is right. There isn't much documentation for this parameter.
There was a problem hiding this comment.
PublishFlatContainer? This just says "I'm a blob not a package". It used to refer to some sleet feed vs. blob artifact pivot.
3 participants
Contributes to dotnet/source-build#4101
Enables publishing in VMR.
Installers are not collected by common arcade publishing infra. All repos that build installers need to collect them in Publishing.props file.
Additionally installers need to be published to correct blob path, which includes versioned sub-directory. I'm obtaining the version value from
MicrosoftWindowsDesktopAppRuntimewinx64PackageVersionproperty which is defined in all architecture builds. This repo does not appear to define any RID-specific properties, i.e.TargetRid.