Skip to content

Enable publishing in VMR #4215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 15, 2024
Merged

Enable publishing in VMR #4215

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
823aa94
Enable publishing in VMR
NikolaMilosavljevic Mar 7, 2024
980d597
Update Publishing.props
ViktorHofer Mar 15, 2024
849fac7
Update Publishing.props
ViktorHofer Mar 15, 2024
db4760b
Update Publishing.props
ViktorHofer Mar 15, 2024
3b946d6
Update Publishing.props
ViktorHofer Mar 15, 2024
83d7216
Update Publishing.props
ViktorHofer Mar 15, 2024
b3bb9d8
Update Publishing.props
ViktorHofer Mar 15, 2024
e4ccaba
Update Publishing.props
ViktorHofer Mar 15, 2024
2943339
Update Publishing.props
ViktorHofer Mar 15, 2024
2190636
Update Publishing.props
ViktorHofer Mar 15, 2024
deb39fb
Update Publishing.props
ViktorHofer Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 30 additions & 4 deletions eng/Publishing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,31 @@
<Project>
<PropertyGroup>
<ProducesDotNetReleaseShippingAssets>true</ProducesDotNetReleaseShippingAssets>
</PropertyGroup>
</Project>

<PropertyGroup>
<ProducesDotNetReleaseShippingAssets>true</ProducesDotNetReleaseShippingAssets>
</PropertyGroup>

<!-- Include installer archives and packages which aren't globbed by default. -->
<Target Name="PublishWindowsDesktopInstallers"
BeforeTargets="BeforePublish"
Condition="'$(DotNetBuildRepo)' == 'true'">
<!-- Retrieve windows desktop runtime pack product version.
Don't stabilize the package version in order to retrieve the VersionSuffix. -->
<MSBuild Projects="$(RepoRoot)src/windowsdesktop/src/sfx/Microsoft.WindowsDesktop.App.Runtime.sfxproj"
Targets="ReturnProductVersion"
Properties="IsShipping=false">
<Output TaskParameter="TargetOutputs" PropertyName="WindowsDesktopRuntimePackProductVersion" />
</MSBuild>

<ItemGroup>
<InstallerToPublish Include="$(ArtifactsPackagesDir)**\*.zip;
$(ArtifactsPackagesDir)**\*.exe;
$(ArtifactsPackagesDir)**\*.msi" />
<ItemsToPushToBlobFeed Include="@(InstallerToPublish)"
IsShipping="true"
ManifestArtifactData="DotNetReleaseShipping=true"
PublishFlatContainer="true"
Copy link
Member

@ViktorHofer ViktorHofer Mar 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche any idea why this metadata is set? Just double checking if this is right. There isn't much documentation for this parameter.

Copy link
Member

@mmitche mmitche Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PublishFlatContainer? This just says "I'm a blob not a package". It used to refer to some sleet feed vs. blob artifact pivot.

Copy link
Member

@ViktorHofer ViktorHofer Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks

RelativeBlobPath="WindowsDesktop/$(WindowsDesktopRuntimePackProductVersion)/%(Filename)%(Extension)" />
</ItemGroup>
</Target>

</Project>