Skip to content

Conversation

@NikolaMilosavljevic
Copy link
Member

Contributes to dotnet/source-build#4101

Enables publishing in VMR.

Some highlights:

  • 10 patches for repo-specific changes including updates to arcade infra
  • significant updates in arcade infra, mostly refactoring several projects to enable source-building them, but also to enable publishing to local build storage
  • changes in 9 repos to enable proper publishing in VMR
  • updated sdk archive discovery path due to proper assets directory layout produced by publishing
  • to enable easy consumption of source-build artifacts, sdk archive gets copied to root of assets dir, next to symbols and PSB archives
  • sbrp packages cannot be published directly to reference packages directory, so they are published to temp location under obj, then copied to refrence dir, after previous sbrps are deleted
  • four new properties are passed to repo build to specify locations for artifacts, used by new task that publishes artifacts to local build storage

Patch backport PRs:

@premun
Copy link
Member

premun commented Mar 11, 2024

Seems like there are still some issues similar to dotnet/arcade-services#3277

I will have a look

@premun
Copy link
Member

premun commented Mar 11, 2024

Seems like there are still some issues similar to dotnet/arcade-services#3277

I will have a look

Fix is here: #18965
Once it merges, merge main here.

@ViktorHofer
Copy link
Member

@premun the sync is now failing in all legs

@premun
Copy link
Member

premun commented Mar 12, 2024

@premun the sync is now failing in all legs

These are just regular conflicts in the patches. The problem I was fixing is Windows only

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great progress 👍 Aside from the repo symbols archive discussions, the manifest location and a few nits, changes look good!

@NikolaMilosavljevic
Copy link
Member Author

Arcade patch does not apply causing source-build and unified-build failures. I'll rebase the patch and update the PR later today when I push some more changes.

@NikolaMilosavljevic
Copy link
Member Author

@mmitche @ViktorHofer there are few more related (or dependent) PRs that might require updates or follow-up work, upon review. I'm mostly interested in runtime changes: dotnet/runtime#99432

@ViktorHofer
Copy link
Member

#19049 is now failing. You might want to include the dependency update into this PR.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some patches are old but it doesn't really matter as they will soon be removed.

@ViktorHofer ViktorHofer merged commit 3384a8d into dotnet:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants