Added missing package references for F# #726
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
requested review from
MichaelSimons,
mthalman and
oleksandr-didyk
as code owners
vzarytovskii
commented
Jun 22, 2023
Comment on lines
-15
to
-16
| All newly added packages should be grouped together at the end of the list. The reason this is | ||
| important is that when previous source-built artifacts are updated, the entries for the new projects |
Member
Author
There was a problem hiding this comment.
Ooops, these were unintentional, my editor removes trailing spaces, do you want me to revert them?
Member
|
I started a discussion on the need for these in dotnet/fsharp#15460. Let's settle on that before merging. |
Member
|
Closing as these aren't necessary for the product source-build. These will be added as allowed prebuilts in dotnet/fsharp#15460. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't run
build.shlocally, since I don't have a linux machine available right now, change is trivial, and hoping for CI to check all necessary things.