Skip to content

Added missing package references for F# #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Added missing package references for F# #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf32017
Added missing package references for F#
vzarytovskii Jun 22, 2023
c085284
Added nowarns
vzarytovskii Jun 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions eng/Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
to the source-build package cache when building with source-build to allow them to be
considered in prebuilt reporting.
All newly added packages should be grouped together at the end of the list. The reason this is
important is that when previous source-built artifacts are updated, the entries for the new projects
Comment on lines -15 to -16
Copy link
Member Author

@vzarytovskii vzarytovskii Jun 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, these were unintentional, my editor removes trailing spaces, do you want me to revert them?

All newly added packages should be grouped together at the end of the list. The reason this is
important is that when previous source-built artifacts are updated, the entries for the new projects
it includes can be removed. New PRs may miss that cut and if they are not grouped at the bottom,
this management becomes more difficult.
Expand Down Expand Up @@ -45,7 +45,7 @@
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.NET.StringTools.17.3.1.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.Build.17.3.1.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.Web.Xdt.3.0.0.csproj" />

<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Threading.Tasks.Extensions.4.5.3.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.CodeAnalysis.Common.3.3.1.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\Microsoft.CodeAnalysis.Workspaces.Common.3.3.1.csproj" />
Expand All @@ -65,6 +65,11 @@
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\NuGet.Commands.6.2.2.csproj" />

<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Security.Cryptography.Pkcs.7.0.2.csproj" />


<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Configuration.ConfigurationManager.7.0.0.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Diagnostics.EventLog.7.0.0.csproj" />
<DependencyPackageProjects Include="$(RepoRoot)src\referencePackages\src\**\System.Security.Cryptography.ProtectedData.7.0.0.csproj" />
</ItemGroup>

<ItemGroup Condition="'$(BuildDependencyPackageProjects)' == 'true'">
Expand Down
1 change: 1 addition & 0 deletions ...uration.configurationmanager/4.7.0/System.Configuration.ConfigurationManager.4.7.0.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<AssemblyName>System.Configuration.ConfigurationManager</AssemblyName>
<ProjectTemplateVersion>2</ProjectTemplateVersion>
<StrongNameKeyId>Open</StrongNameKeyId>
<NoWarn>$(NoWarn);SYSLIB0003</NoWarn>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
Expand Down
1 change: 1 addition & 0 deletions ...uration.configurationmanager/6.0.0/System.Configuration.ConfigurationManager.6.0.0.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<AssemblyName>System.Configuration.ConfigurationManager</AssemblyName>
<ProjectTemplateVersion>2</ProjectTemplateVersion>
<StrongNameKeyId>Open</StrongNameKeyId>
<NoWarn>$(NoWarn);SYSLIB0003</NoWarn>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
Expand Down
27 changes: 27 additions & 0 deletions ...uration.configurationmanager/7.0.0/System.Configuration.ConfigurationManager.7.0.0.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net6.0;net7.0;netstandard2.0</TargetFrameworks>
<AssemblyName>System.Configuration.ConfigurationManager</AssemblyName>
<ProjectTemplateVersion>2</ProjectTemplateVersion>
<StrongNameKeyId>Open</StrongNameKeyId>
<NoWarn>$(NoWarn);SYSLIB0003</NoWarn>
</PropertyGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net6.0'">
<PackageReference Include="System.Security.Cryptography.ProtectedData" Version="7.0.0" />
<PackageReference Include="System.Security.Permissions" Version="7.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'net7.0'">
<PackageReference Include="System.Diagnostics.EventLog" Version="7.0.0" />
<PackageReference Include="System.Security.Cryptography.ProtectedData" Version="7.0.0" />
<PackageReference Include="System.Security.Permissions" Version="7.0.0" />
</ItemGroup>

<ItemGroup Condition="'$(TargetFramework)' == 'netstandard2.0'">
<PackageReference Include="System.Security.Cryptography.ProtectedData" Version="7.0.0" />
<PackageReference Include="System.Security.Permissions" Version="7.0.0" />
</ItemGroup>

</Project>
Loading