[release/net8] Update dependencies from dotnet/source-build-reference-packages

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

• Subscription: b3e982ed-8e74-4d0e-ed80-08db6176a378
• Build: 20230623.1
• Date Produced: June 23, 2023 6:27:39 PM UTC
• Commit: e910f7bdd090fb8f4a9122a1054a8b43a006b0a7
• Branch: refs/heads/main

• Updates:
  • Microsoft.SourceBuild.Intermediate.source-build-reference-packages: from 8.0.0-alpha.1.23316.2 to 8.0.0-alpha.1.23323.1

[vzarytovskii]

@NikolaMilosavljevic @mmitche we again have source build issues in few PRs, could you please advise on what can we do to fix it?

[NikolaMilosavljevic]

@NikolaMilosavljevic @mmitche we again have source build issues in few PRs, could you please advise on what can we do to fix it?

@vzarytovskii this is a perfect example for why we did the source-build work to enable prebuilt detection in individual repos. Prebuilt detection, at repo level, saves a lot of time and headaches during full product source-build and enables .NET to deliver the product to partners on time. While these types of changes are rare, at the individual repo level, they do require some simple additional work to get them resolved.

You would need to generate new reference packages for the 3 packages flagged by source-build:

System.Configuration.ConfigurationManager.7.0.0
System.Diagnostics.EventLog.7.0.0
System.Security.Cryptography.ProtectedData.7.0.0

Here are the steps for resolving this issue:

1. Fork the SBRP repo: https://github.com/dotnet/source-build-reference-packages
2. Generate new packages, using the following command, and add all generated files. Sample command for one of the packages:
   ./generate.sh --package System.Configuration.ConfigurationManager,7.0.0 -x
3. Add new dependency entries in https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props, at the end of the list of other DependencyPackageProjects elements, making sure to add one empty line, for visual separation. Sample entry, for one of the packages - all 3 are needed:
   Include="$(RepoRoot)src\referencePackages\src\**\System.Configuration.ConfigurationManager.7.0.0.csproj" />
4. Commit your changes and do a local build using:
   ./build.sh -sb
5. If successful, create a PR.
6. After PR is approved and merged, the build will be automatically kicked off to produce new Microsoft.SourceBuild.Intermediate.source-build-reference-packages (SBRP intermediate) package
7. Wait until SBRP intermediate package is available, in an hour or so - use darc to discover the Version and Sha.
   darc get-asset --name Microsoft.SourceBuild.Intermediate.source-build-reference-packages --max-age 1
8. Update your pending PR to incorporate just-built SBRP intermediate package: https://github.com/dotnet/razor/blob/8fd856fd9047679753a451a4224605e67e83a9bc/eng/Version.Details.xml#L8C31-L12

Let me know if you hit any issues, with any of these steps.

[vzarytovskii]

@NikolaMilosavljevic @mmitche we again have source build issues in few PRs, could you please advise on what can we do to fix it?

@vzarytovskii this is a perfect example for why we did the source-build work to enable prebuilt detection in individual repos. Prebuilt detection, at repo level, saves a lot of time and headaches during full product source-build and enables .NET to deliver the product to partners on time. While these types of changes are rare, at the individual repo level, they do require some simple additional work to get them resolved.

You would need to generate new reference packages for the 3 packages flagged by source-build:

System.Configuration.ConfigurationManager.7.0.0
System.Diagnostics.EventLog.7.0.0
System.Security.Cryptography.ProtectedData.7.0.0

Here are the steps for resolving this issue:

1. Fork the SBRP repo: https://github.com/dotnet/source-build-reference-packages
2. Generate new packages, using the following command, and add all generated files. Sample command for one of the packages:
   ./generate.sh --package System.Configuration.ConfigurationManager,7.0.0 -x
3. Add new dependency entries in https://github.com/dotnet/source-build-reference-packages/blob/main/eng/Build.props, at the end of the list of other DependencyPackageProjects elements, making sure to add one empty line, for visual separation. Sample entry, for one of the packages - all 3 are needed:
   Include="$(RepoRoot)src\referencePackages\src\**\System.Configuration.ConfigurationManager.7.0.0.csproj" />
4. Commit your changes and do a local build using:
   ./build.sh -sb
5. If successful, create a PR.
6. After PR is approved and merged, the build will be automatically kicked off to produce new Microsoft.SourceBuild.Intermediate.source-build-reference-packages (SBRP intermediate) package
7. Wait until SBRP intermediate package is available, in an hour or so - use darc to discover the Version and Sha.
   darc get-asset --name Microsoft.SourceBuild.Intermediate.source-build-reference-packages --max-age 1
8. Update your pending PR to incorporate just-built SBRP intermediate package: https://github.com/dotnet/razor/blob/8fd856fd9047679753a451a4224605e67e83a9bc/eng/Version.Details.xml#L8C31-L12

Let me know if you hit any issues, with any of these steps.

Ah, got it. Thanks, will do tomorrow.

[MichaelSimons]

I am not certain these should be added to SBRP. These packages are not being referenced in the full product source-build, they only appear when building at the repo level. Investigating this, it looks like these are transitive dependencies from the .NETCopeApp package being referenced. In the full product source-build the latest 8.0 NETCoreApp package is referenced which in turn refernces the 8.0 versions of these dependencies.

We only want SBRP to contain the reference packages require in the full product source-build. Because of that, I feel these should be added to the prebuilt baseline with a note indicating they are transitive packages of .NETCoreApp.

[oleksandr-didyk]

We only want SBRP to contain the reference packages require in the full product source-build. Because of that, I feel these should be added to the prebuilt baseline with a note indicating they are transitive packages of .NETCoreApp.

Should we maybe extend existing pre-built detection docs to include this situation?

[vzarytovskii]

I am not certain these should be added to SBRP. These packages are not being referenced in the full product source-build, they only appear when building at the repo level. Investigating this, it looks like these are transitive dependencies from the .NETCopeApp package being referenced. In the full product source-build the latest 8.0 NETCoreApp package is referenced which in turn refernces the 8.0 versions of these dependencies.

We only want SBRP to contain the reference packages require in the full product source-build. Because of that, I feel these should be added to the prebuilt baseline with a note indicating they are transitive packages of .NETCoreApp.

Alright, shall we add those to the baseline then?

[MichaelSimons]

Alright, shall we add those to the baseline then?

Yes please do that. Use the following pattern:

<UsagePattern IdentityGlob="System.Text.Encodings.Web/*8.0.0*" />

Should we maybe extend existing pre-built detection docs to include this situation?

Yes, please.