Enable publishing in VMR

[NikolaMilosavljevic]

Contributes to dotnet/source-build#4101

Enables publishing in VMR.

This repo creates packages in locations that aren't collected by common publishing infra in arcade. We need to collect them here.

[NikolaMilosavljevic]

Will update this to match similar changes in symreader and fsharp.

[ViktorHofer]

Why is this PR needed? Isn't that the default? Which packages aren't picked up?

[mmitche]

Yeah, agreed that these should already be the defaults

[ViktorHofer]

https://github.com/dotnet/arcade/blob/0f35699621fdb3a08fa2840c9d6d08769438e243/src/Microsoft.DotNet.Arcade.Sdk/tools/Publish.proj#L84-L85

Interestingly publishing looks at artifacts/packages/shipping and nonshipping while signing looks at artifacts/packages/*: https://github.com/dotnet/arcade/blob/0f35699621fdb3a08fa2840c9d6d08769438e243/src/Microsoft.DotNet.Arcade.Sdk/tools/Sign.props#L14

I think this should be aligned eventually, maybe with the VMR signing work.

[mmitche]

I think there is some subtlety here. The release package generation (generates release and prerelease versions of the shipping packages) sticks everything under packages\Release and packages\PreRelease. All of it needs to be signed, but only the shipping and nonshipping dirs are reported to BAR for dependency flow.

[NikolaMilosavljevic]

Yeah - these packages are not picked by Arcade infra as it's more restrictive in folder set for nupkg collection. We need this change.

[ViktorHofer]

@NikolaMilosavljevic which packages are currently not picked up by publishing? Please give an example.

[NikolaMilosavljevic]

@NikolaMilosavljevic which packages are currently not picked up by publishing? Please give an example.

With changes in this PR, all SBE packages are picked up. Without the changes, none of the packages are picked up. Just 2 examples:

Humanizer.Core.2.14.1.nupkg
Microsoft.ApplicationInsights.2.21.0.nupkg

This is due to different sub-folder naming in packages folder. Default arcade infra collects packages from Shipping and NonShipping folders. SBE packages are in Release sub-folder.

[ViktorHofer]

SBE packages are in Release sub-folder.

Interesting. Why is that so?

[ViktorHofer]

Approving to get things flowing but we should follow-up on why SBE puts the artifacts under packages/Release instead of the expected directories.

[ViktorHofer]

@NikolaMilosavljevic I don't think this line is necessary and should probably be deleted. Please also add a tracking issue for investigating why packages are not in the expected subfolders.

[NikolaMilosavljevic]

Created an issue to fix this and remove custom publishing infra: dotnet/source-build#4235