Skip to content

Enable publishing in VMR #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Enable publishing in VMR #275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
83e576f
Enable publishing in VMR
NikolaMilosavljevic Mar 7, 2024
bf05c54
Merge branch 'main' into publish
NikolaMilosavljevic Mar 8, 2024
fee4ad0
Merge branch 'main' into publish
NikolaMilosavljevic Mar 13, 2024
aac8560
Trim publishing.props file
NikolaMilosavljevic Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions eng/Publishing.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<PublishingVersion>3</PublishingVersion>
</PropertyGroup>

<ItemGroup>
<ItemsToPushToBlobFeed Include="$(ArtifactsPackagesDir)**\*.nupkg"
IsShipping="true"
UploadPathSegment="Runtime"
Copy link
Member

@ViktorHofer ViktorHofer Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikolaMilosavljevic I don't think this line is necessary and should probably be deleted. Please also add a tracking issue for investigating why packages are not in the expected subfolders.

Copy link
Member Author

@NikolaMilosavljevic NikolaMilosavljevic Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an issue to fix this and remove custom publishing infra: dotnet/source-build#4235

Condition="'$(DotNetBuildSourceOnly)' == 'true'" />
</ItemGroup>

</Project>