Skip to content

Conversation

@v-wuzhai
Copy link
Contributor

@v-wuzhai v-wuzhai commented Jun 14, 2023

Fixes #33196

The NETSDK1183 of the main branch is different from other branches.

@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Jun 14, 2023
@v-wuzhai v-wuzhai requested a review from marcpopMSFT June 14, 2023 05:36
@marcpopMSFT marcpopMSFT requested a review from sbomer June 14, 2023 20:06
@marcpopMSFT
Copy link
Member

This message was changed in #32943 from Sven. Looks like he took one error and split into three and reused the existing error code. I think this PR is correct to take as then documentation on 7.0 SDKs can include the old 1183 error and documentation in 8.0 will have the new error under a different number but I want @sbomer to review in case there is any existing documentation that refers to these errors (new or old).

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the only docs I'm aware of reference the old text of NETSDK1183 (https://learn.microsoft.com/en-us/dotnet/core/tools/sdk-errors/).

@marcpopMSFT
Copy link
Member

Thanks. That should work then as the doc will be for the older version of the SDK. @tdykstra how did you want to mark NETSDK errors that have been removed in later SDKs in that document?

@marcpopMSFT marcpopMSFT merged commit 7cbb54b into main Jun 14, 2023
@marcpopMSFT marcpopMSFT deleted the v-wuzhai/Fix-duplicate-error-codes branch June 14, 2023 21:46
@tdykstra
Copy link
Contributor

@tdykstra how did you want to mark NETSDK errors that have been removed in later SDKs in that document?

In that document we could do something like this:

SDK Message Number Message
NETSDK1183 .NET 7 only - Unable to optimize assemblies for Ahead of time compilation: a valid runtime package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-Infrastructure untriaged Request triage from a team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix error code to maintain consistency

5 participants