Improve errors about unsupported aot scenarios #32943
Merged
+287
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
jkotas
approved these changes
May 31, 2023
MichalStrehovsky
approved these changes
Jun 1, 2023
sbomer
added a commit
to dotnet/installer
that referenced
this pull request
Jun 1, 2023
Attempting to publish AOT on an unsupported host, or with an unsupported target RID, will produce an error in the SDK before trying to restore the ILCompiler packages. This uses the RID list in `KnownILCompilerPack` as the source of truth for what is considered supported. Then with improved error reporting (dotnet/sdk#32943), this will give enough info to the user about why a scenario isn't supported for aot. Failing before restore does mean that advanced users who want to test with unsupported ILC packages need to use a different workaround. Instead of adding a `PackageReference`, they'll need something like this: ```xml <ItemGroup> <KnownILCompilerPack Update="@(KnownILCompilerPack)"> <ILCompilerRuntimeIdentifiers>unsupported-rid</ILCompilerRuntimeIdentifiers> </KnownILCompilerPack> </ItemGroup> ```
dotnet-bot
pushed a commit
to dotnet/dotnet
that referenced
this pull request
Jun 1, 2023
…6545) Attempting to publish AOT on an unsupported host, or with an unsupported target RID, will produce an error in the SDK before trying to restore the ILCompiler packages. This uses the RID list in `KnownILCompilerPack` as the source of truth for what is considered supported. Then with improved error reporting (dotnet/sdk#32943), this will give enough info to the user about why a scenario isn't supported for aot. Failing before restore does mean that advanced users who want to test with unsupported ILC packages need to use a different workaround. Instead of adding a `PackageReference`, they'll need something like this: ```xml <ItemGroup> <KnownILCompilerPack Update="@(KnownILCompilerPack)"> <ILCompilerRuntimeIdentifiers>unsupported-rid</ILCompilerRuntimeIdentifiers> </KnownILCompilerPack> </ItemGroup> ``` Original commit: dotnet/installer@5acae40 [[ commit created by automation ]]
|
And of course "runtime pack" is one word in German: "Laufzeitpaket". 😆 |
This was referenced Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the errors when there's no
KnownILCompilerPackto include more detailed information. There are now separate errors for an unsupported host RID, unsupported target RID, and unsupported TFM (the existing warning).Partial fix for dotnet/runtime#84583. The other piece is in dotnet/installer#16545.