Skip to content

Fix duplicate NETSDK1183 #33228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix duplicate NETSDK1183 #33228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
666d599
Fix duplicate NETSDK1183
Jun 14, 2023
113211f
Fix failed tests
Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/Tasks/Common/Resources/Strings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,10 +835,6 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1182: Targeting .NET 6.0 or higher in Visual Studio 2019 is not supported.</value>
<comment>{StrBegin="NETSDK1182: "}</comment>
</data>
<data name="AotUnsupportedTargetFramework" xml:space="preserve">
<value>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</value>
<comment>{StrBegin="NETSDK1183: "}</comment>
</data>
<data name="TargetingPackNotRestored_TransitiveDisabled" xml:space="preserve">
<value>NETSDK1184: The Targeting Pack for FrameworkReference '{0}' was not available. This may be because DisableTransitiveFrameworkReferenceDownloads was set to true.</value>
<comment>{StrBegin="NETSDK1184: "}</comment>
Expand Down Expand Up @@ -928,4 +924,8 @@ You may need to build the project on another operating system or architecture, o
<value>NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): {0}. Affected libraries: {1}. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details.</value>
<comment>{StrBegin="NETSDK1206: "}</comment>
</data>
<data name="AotUnsupportedTargetFramework" xml:space="preserve">
<value>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</value>
<comment>{StrBegin="NETSDK1207: "}</comment>
</data>
</root>
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.cs.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.de.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.es.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.fr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.it.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.ja.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.ko.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.pl.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.pt-BR.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.ru.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.tr.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hans.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
6 changes: 3 additions & 3 deletions src/Tasks/Common/Resources/xlf/Strings.zh-Hant.xlf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
<note>{StrBegin="NETSDK1204: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetFramework">
<source>NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1183: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1183: "}</note>
<source>NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</source>
<target state="new">NETSDK1207: Ahead-of-time compilation is not supported for the target framework.</target>
<note>{StrBegin="NETSDK1207: "}</note>
</trans-unit>
<trans-unit id="AotUnsupportedTargetRuntimeIdentifier">
<source>NETSDK1203: Ahead-of-time compilation is not supported for the target runtime identifier '{0}'.</source>
Expand Down
4 changes: 2 additions & 2 deletions src/Tests/Microsoft.NET.Publish.Tests/GivenThatWeWantToPublishAnAotApp.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ public void NativeAot_hw_fails_with_sdk6_PublishAot_is_enabled()
publishCommand
.Execute($"/p:UseCurrentRuntimeIdentifier=true")
.Should().Fail()
.And.HaveStdOutContaining("error NETSDK1183:");
.And.HaveStdOutContaining("error NETSDK1207:");
}
}

Expand All @@ -506,7 +506,7 @@ public void NativeAot_hw_fails_with_sdk6_PackageReference_PublishAot_is_enabled(
publishCommand
.Execute($"/p:UseCurrentRuntimeIdentifier=true")
.Should().Fail()
.And.HaveStdOutContaining("error NETSDK1183:");
.And.HaveStdOutContaining("error NETSDK1207:");
}
}

Expand Down