Remove ILStrip usage in mono for source-build #63593
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet#60315 tried to remove ILStrip usage in runtime for source-build (through a condition of DotNetBuildFromSource) but it didn't remove the prebuilts in mono. Fix that. We needed this for building .NET 6 on using source-build on IBM Z.
ghost
added
community-contribution
Member
Author
|
Uh.. this is a duplicate of #61607, which has been stalled since Nov. Sorry for the noise. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60315 tried to remove ILStrip usage in runtime for source-build (through a condition of DotNetBuildFromSource) but it didn't remove the prebuilts in mono. Fix that.
We needed this for building .NET 6 on using source-build on IBM Z.
cc @uweigand who wrote this patch; I am only trying to get it merged here so we don't have to carry this locally.