[source-build][mono] Do not build Microsoft.NET.Runtime.MonoTargets.Sdk #61607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Does not build due to missing Microsoft.DotNet.CilStrip.Sources external dependency in source-build. * Package is not needed for source-build anyway.
ghost
added
community-contribution
steveisok
approved these changes
Nov 15, 2021
Member
steveisok
left a comment
steveisok
left a comment
There was a problem hiding this comment.
As long as you don't have a need to distribute the package, this change is fine.
Member
|
Would it be possible to merge this? Does this seem safe to backport to 6.0? |
Member
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1689629333 |
Member
|
Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does not build due to missing Microsoft.DotNet.CilStrip.Sources
external dependency in source-build.
Package is not needed for source-build anyway.
CC @omajid @tmds @crummel @akoeplinger @steveisok