Skip to content

Conversation

@eerhardt
Copy link
Member

This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.

  1. Remove RefOnly dependency versions
    This allows for source-build to replace these versions with source-built versions.
  2. Eliminate usages of pre-built packages during source-build
    See commit message for details

cc @MichaelSimons @dseefeld @ericstj

This allows for source-build to replace these versions with source-built versions.
* Don't build MSBuild tasks for netfx during source-build
* Don't build Microsoft.Windows.Compatibility during source-build
* Don't build test projects during source-build
* Don't restore Microsoft.DiaSymReader.Native
* Don't build source generators that target older Roslyn versions
* Don't build ILStripTask since it uses a Mono.Cecil "sources" NuGet package that isn't part of source-build
@ghost
Copy link

ghost commented Oct 12, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 13, 2021

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This work eliminates using pre-built NuGet packages during source-build. It's probably easiest to review commit-by-commit.

  1. Remove RefOnly dependency versions
    This allows for source-build to replace these versions with source-built versions.
  2. Eliminate usages of pre-built packages during source-build
    See commit message for details

cc @MichaelSimons @dseefeld @ericstj

Author: eerhardt
Assignees: -
Labels:

area-Infrastructure

Milestone: -

Fix test build
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anipik
Copy link
Contributor

Anipik commented Oct 13, 2021

SendPacketsElement_FileStreamLargeOffset_Throws has been failing quite frequently in CI. @karelz do we need a new issue for this one ?

Merging this PR as the failure is unreleated and its a tell mode change

@Anipik Anipik merged commit f9e82e6 into dotnet:release/6.0 Oct 13, 2021
@eerhardt eerhardt deleted the SourceBuildWork branch October 13, 2021 14:25
@ghost ghost locked as resolved and limited conversation to collaborators Nov 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants