Fix MemoryMarshal.Cast implicit conversion error after Roslyn update #121414
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng byte array to Span Co-authored-by: sbomer <[email protected]>
Copilot
AI
changed the title
[WIP] Update dependencies from dotnet/roslyn
Fix MemoryMarshal.Cast implicit conversion error after Roslyn update
Nov 6, 2025
Copilot finished work on behalf of
sbomer
November 6, 2025 17:59
sbomer
approved these changes
Nov 6, 2025
sbomer
merged commit df29b24
into
darc-release/9.0-staging-4da6a74f-9a77-4837-ae86-0b0dfcd7a5bd
9 of 11 checks passed
sbomer
added a commit
that referenced
this pull request
Nov 14, 2025
…121601) Fixes compilation error introduced by Roslyn 4.14.0's stricter type checking for array-to-span conversions. main PR: #121343 # Description Roslyn 4.14.0 no longer allows implicit conversion from `string[]` to `Span<string?>`. Fixed by explicitly converting arrays to spans in `HttpHeaders.GetStoreValuesIntoStringArray`: ```csharp // Before ReadStoreValues<object?>(values, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); // After ReadStoreValues<object?>(values.AsSpan(), info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); ``` # Customer Impact Blocks servicing release builds. No runtime behavior change. # Regression No - compiler enforcement tightening from dependency update. # Testing Verified compilation fix. No functional changes to test. # Risk Minimal. Surgical two-line change converts array to span where method signature already required it. Identical pattern to fixes in #121414 and BigInteger.cs (46bb931). <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sbomer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Roslyn 4.14.0 compiler update introduced stricter type checking for
MemoryMarshal.Castwhen called directly on arrays, now returningReadOnlySpan<T>instead ofSpan<T>.Changes
Span<byte>before casting toSpan<int>to preserve write accessThe writable span is required since the code modifies elements via
newDbInts[i] -= locationOffset.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.