-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/9.0-staging] Update dependencies from dotnet/roslyn #121343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/9.0-staging
Are you sure you want to change the base?
[release/9.0-staging] Update dependencies from dotnet/roslyn #121343
Conversation
…915.8 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25467.18 -> To Version 4.14.0-3.25465.8 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25465.8
|
Failures with /cc @jeffhandley |
|
@copilot fix the error: |
…121414) The Roslyn 4.14.0 compiler update introduced stricter type checking for `MemoryMarshal.Cast` when called directly on arrays, now returning `ReadOnlySpan<T>` instead of `Span<T>`. ## Changes - **JsonDocument.MetadataDb.cs**: Explicitly convert byte array to `Span<byte>` before casting to `Span<int>` to preserve write access ```csharp // Before Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase); // After Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase.AsSpan()); ``` The writable span is required since the code modifies elements via `newDbInts[i] -= locationOffset`. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sbomer <[email protected]>
|
@copilot fix the error: src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs(387,65): error CS1503: (NETCORE_ENGINEERING_TELEMETRY=Build) Argument 1: cannot convert from 'System.ReadOnlySpan' to 'System.Span' |
|
@steveisok I've opened a new pull request, #121501, to work on those changes. Once the pull request is ready, I'll request review from you. |
…110.12 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25467.18 -> To Version 4.14.0-3.25560.12 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25560.12
Commit message of the cherry-picked commit (note this branch now references newer versions): Update dependencies from dotnet/roslyn (#110105) * Update dependencies from https://github.com/dotnet/roslyn build 20241122.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241122.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24572.15 * Update dependencies from https://github.com/dotnet/roslyn build 20241124.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-2.24574.5 * Update dependencies from https://github.com/dotnet/roslyn build 20241125.18 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24575.18 * Update dependencies from https://github.com/dotnet/roslyn build 20241127.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24577.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241128.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241128.3 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24578.3 * Update dependencies from https://github.com/dotnet/roslyn build 20241130.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.1 * Update dependencies from https://github.com/dotnet/roslyn build 20241130.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24580.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241201.2 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24601.2 * Update dependencies from https://github.com/dotnet/roslyn build 20241202.26 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.13.0-2.24570.4 -> To Version 4.13.0-3.24602.26 * Use explicit AsSpan * Fix LibraryImportGenerator.UnitTests * Fix regex tests * Adjust trimming test for new codegen With this roslyn update, the generated iterator state machine for this test includes a Dispose method which assigns null to the array, inhibiting dataflow analysis. --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Sven Boemer <[email protected]>
|
@copilot fix this error: src/libraries/System.Net.Http/src/System/Net/Http/Headers/HttpHeaders.cs(1209,42): error CS8620: (NETCORE_ENGINEERING_TELEMETRY=Build) Argument of type 'string[]' cannot be used for parameter 'values' of type 'Span<string?>' in 'void HttpHeaders.ReadStoreValues<string?>(Span<string?> values, object? storeValue, HttpHeaderParser? parser, ref int currentIndex)' due to differences in the nullability of reference types. |
…121601) Fixes compilation error introduced by Roslyn 4.14.0's stricter type checking for array-to-span conversions. main PR: #121343 # Description Roslyn 4.14.0 no longer allows implicit conversion from `string[]` to `Span<string?>`. Fixed by explicitly converting arrays to spans in `HttpHeaders.GetStoreValuesIntoStringArray`: ```csharp // Before ReadStoreValues<object?>(values, info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); // After ReadStoreValues<object?>(values.AsSpan(), info.ParsedAndInvalidValues, descriptor.Parser, ref currentIndex); ``` # Customer Impact Blocks servicing release builds. No runtime behavior change. # Regression No - compiler enforcement tightening from dependency update. # Testing Verified compilation fix. No functional changes to test. # Risk Minimal. Surgical two-line change converts array to span where method signature already required it. Identical pattern to fixes in #121414 and BigInteger.cs (46bb931). <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey). --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: sbomer <[email protected]>
Commit message of the cherry-picked commit (note this branch now references newer versions): Update Roslyn to 4.13.0-1.24510.9 (#109467) * Update Roslyn to 4.13.0-1.24510.9 * Update roslyn-analyzers * Fix first-class Span breaks * Remove LangVersion=latest * Fixup more places * Updates and fixes --------- Co-authored-by: Jan Jones <[email protected]>
…a74f-9a77-4837-ae86-0b0dfcd7a5bd
…120.7 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25569.8 -> To Version 4.14.0-3.25570.7 Microsoft.CodeAnalysis.Analyzers From Version 3.11.0-beta1.25173.3 -> To Version 3.12.0-beta1.25570.7
Commit message of the cherry-picked commit (note this branch now references newer versions): [main] Update dependencies from dotnet/roslyn (#112937) * Update dependencies from https://github.com/dotnet/roslyn build 20250225.8 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25125.8 * Update dependencies from https://github.com/dotnet/roslyn build 20250226.5 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25126.5 * Update dependencies from https://github.com/dotnet/roslyn build 20250303.7 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25153.7 * Update dependencies from https://github.com/dotnet/roslyn build 20250304.7 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25154.7 * Update dependencies from https://github.com/dotnet/roslyn build 20250305.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25155.15 * Update dependencies from https://github.com/dotnet/roslyn build 20250307.4 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25157.4 * Update dependencies from https://github.com/dotnet/roslyn build 20250310.11 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25160.11 * Update dependencies from https://github.com/dotnet/roslyn build 20250311.7 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25161.7 * Update dependencies from https://github.com/dotnet/roslyn build 20250312.12 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25162.12 * Update dependencies from https://github.com/dotnet/roslyn build 20250313.9 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25163.9 * Update dependencies from https://github.com/dotnet/roslyn build 20250314.6 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25164.6 * Update dependencies from https://github.com/dotnet/roslyn build 20250314.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25164.10 * Update dependencies from https://github.com/dotnet/roslyn build 20250317.7 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25167.7 * Update dependencies from https://github.com/dotnet/roslyn build 20250318.15 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25168.15 * Update dependencies from https://github.com/dotnet/roslyn build 20250319.7 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25169.7 * Update dependencies from https://github.com/dotnet/roslyn build 20250320.13 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25170.13 * Update dependencies from https://github.com/dotnet/roslyn build 20250321.23 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25171.23 * Update dependencies from https://github.com/dotnet/roslyn build 20250321.27 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25171.27 * Update dependencies from https://github.com/dotnet/roslyn build 2025032.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25174.10 * Update dependencies from https://github.com/dotnet/roslyn build 20250325.12 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25175.12 * Update dependencies from https://github.com/dotnet/roslyn build 20250326.10 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25176.10 * Update dependencies from https://github.com/dotnet/roslyn build 20250327.9 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25177.9 * Update dependencies from https://github.com/dotnet/roslyn build 20250328.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25178.1 * Update dependencies from https://github.com/dotnet/roslyn build 20250329.1 Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.14.0-2.25121.3 -> To Version 4.14.0-3.25179.1 * Fix compiler warning around unused fields - needed for Unsafe. * Allow prebuilts for roslyn's dependencies --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Larry Ewing <[email protected]> Co-authored-by: Eric StJohn <[email protected]>
…120.7 On relative base path root Microsoft.SourceBuild.Intermediate.roslyn , Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.CSharp , Microsoft.Net.Compilers.Toolset From Version 4.12.0-3.25569.8 -> To Version 4.14.0-3.25570.7
This pull request updates the following dependencies
From https://github.com/dotnet/roslyn