Skip to content

Fix MemoryMarshal.Cast implicit conversion error after Roslyn update #121414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2025
+1 −1
Merged

Fix MemoryMarshal.Cast implicit conversion error after Roslyn update #121414

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520998a
Initial plan
Copilot Nov 6, 2025
be0212e
Fix CS0029 error in JsonDocument.MetadataDb.cs by explicitly converti…
Copilot Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonDocument.MetadataDb.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ internal MetadataDb CopySegment(int startIndex, int endIndex)
byte[] newDatabase = new byte[length];
_data.AsSpan(startIndex, length).CopyTo(newDatabase);

Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase);
Span<int> newDbInts = MemoryMarshal.Cast<byte, int>(newDatabase.AsSpan());
int locationOffset = newDbInts[0];

// Need to nudge one forward to account for the hidden quote on the string.
Expand Down