Skip to content

Conversation

@tdykstra
Copy link
Contributor

@tdykstra tdykstra commented Jun 5, 2020

Fixes #18512
Fixes #18513
Fixes #18749

In addition to creating the VS Mac series, this PR makes the 3 "swim lanes" as similar as possible, so some changes were made to the VS and VS Code series as well.

@tdykstra tdykstra marked this pull request as ready for review June 9, 2020 15:56
@tdykstra tdykstra requested a review from a team as a code owner June 9, 2020 15:56
@tdykstra tdykstra requested review from BillWagner and CamSoper and removed request for a team June 9, 2020 15:56
@tdykstra tdykstra changed the title WIP: VS Mac .NET Core tutorials VS Mac .NET Core tutorials Jun 9, 2020

The program displays the string that the user enters. What happens if the user doesn't enter anything? You can test this with a useful debugging feature called a *conditional breakpoint*.

1. Right-click (<kbd>Ctrl</kbd>+click on macOS) on the red dot that represents the breakpoint. In the context menu, select **Edit Breakpoint** to open a dialog that lets you enter a conditional expression.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is the reason not to use <kbd> here? I ask because I use it everywhere and now I'm wondering if I shouldn't.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ctrl-click seems to be a special case mixing keyboard and mouse, so I decided to leave it the way it was in the Mac tutorials as they already existed. I'm happy to change if you've seen Mac tutorials using <kbd>Ctrl</kbd>-click

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @BillWagner on how best to render control-click for macOS in tutorials

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm. I don't have a clear recommendation. I think the <kbd>Ctrl</kbd>-click is best.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A related issue: given that Macs have keyboard labels all in lowercase (enter, control, option, command, etc., should those keys be represented by, e.g., <kbd>command</kbd> or <kbd>Command</kbd>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with the earlier question, I don't have an answer here. I think we will set the standard.

My weakly held proposal: go with lower case to match the keyboard labels.

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also LGTM. You can :shipit: when ready.

1. Select the **Terminal** tab, and press any key to exit the program and stop debugging.

1. Clear the breakpoint by clicking on the dot in the left margin of the code window. Another way to clear a breakpoint is by pressing <kbd>F9</kbd> while the line of code is selected.
1. Clear the breakpoint by clicking on the dot in the left margin of the code window. Another way to clear a breakpoint is by choosing **Run > Toggle Breakpoint** while the line of code is selected.
Copy link
Contributor

@Thraka Thraka Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other steps have a "or press KEY" alternative, this one was removed, I think it should be added back 😄

Copy link
Contributor Author

@tdykstra tdykstra Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was to make it more mac-friendly by not mentioning function keys, and it seemed to me not a loss because you see the keyboard shortcut on the menu when you do the menu selection. But I'll add the F9 text for the set and clear breakpoint steps.


A *breakpoint* temporarily interrupts the execution of the application before the line with the breakpoint is executed.

1. Set a breakpoint on the line that displays the name, date, and time. To do that, place the cursor in the line of code and press ⌘ \\ (<kbd>Command</kbd>+<kbd>\\</kbd>). Another way to set a breakpoint is by selecting **Run** > **Toggle Breakpoint** from the menu.
Copy link
Contributor

@Thraka Thraka Jun 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using <kbd>⌘</kbd> for the symbols? Looks like this: +

@tdykstra tdykstra closed this Jun 10, 2020
@tdykstra tdykstra reopened this Jun 10, 2020
@tdykstra tdykstra closed this Jun 10, 2020
@tdykstra tdykstra reopened this Jun 10, 2020
@tdykstra tdykstra merged commit 40d05f7 into dotnet:master Jun 10, 2020
@tdykstra tdykstra deleted the vsmtut branch June 10, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

5 participants