Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 10, 2020

"using-on-mac-vs-full-solution.md" was removed in #18819, so these samples became unused.

cc: @tdykstra

@Youssef1313 Youssef1313 requested a review from a team as a code owner July 10, 2020 15:08
@dotnet-bot dotnet-bot added this to the July 2020 milestone Jul 10, 2020
@Youssef1313
Copy link
Member Author

##[error]😵 Project missing. A project (and optionally a solution file) must be in this directory or one of the parent directories to validate and build this code.

@adegeo, Is that related to my changes?

@adegeo
Copy link
Contributor

adegeo commented Jul 10, 2020

We don't have logic yet to handle deleted files. So these errors can be ignored.

@adegeo
Copy link
Contributor

adegeo commented Jul 10, 2020

@tdykstra I'll let you review. I didn't see anything wrong with this but I believe you made changes in this area last.

@adegeo adegeo requested review from tdykstra and removed request for a team July 10, 2020 15:48
@tdykstra tdykstra merged commit 8bca730 into dotnet:master Jul 10, 2020
@Youssef1313 Youssef1313 deleted the delete-unused-snippets branch July 10, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants