Skip to content

Conversation

@halter73
Copy link
Member

@BrennanConroy It looks like the 1 second timeouts snuck in shortly after #25639 was merged. We should stick to 30 second timeouts for now on.

Addresses #25928

Note to self: Be careful to remember to undo the addition of the Ignore attribute that will be added by #25932 before merging

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Sep 16, 2020
@halter73 halter73 requested a review from jkotalik September 16, 2020 00:59
@BrennanConroy
Copy link
Member

It looks like the 1 second timeouts snuck in shortly after #25639 was merged. We should stick to 30 second timeouts for now on.

Yep, anything new is using the 30 seconds, but everything before that change went in has to manually be changed to 30 and that's easy to forget. So a couple things might slip through.

@BrennanConroy
Copy link
Member

Wow, my UI lagged when VS opened at the same time as trying to click comment

@jkotalik
Copy link
Contributor

@halter73 I merged my quarantine PR so you may need to rebase this to remove the "Disabled" attribute

@halter73 halter73 merged commit a5b6cda into master Sep 17, 2020
@halter73 halter73 deleted the halter73/25928 branch September 17, 2020 21:03
@pranavkm
Copy link
Contributor

@halter73
Copy link
Member Author

Sounds like a good idea. I approved your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants