Skip to content

Commit a5b6cda

Browse files
authored
Increase more SignalR Java client test timeouts (#25934)
1 parent 47adc68 commit a5b6cda

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/HubConnectionTest.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import java.util.concurrent.atomic.AtomicReference;
1818

1919
import org.junit.jupiter.api.Test;
20-
import org.junit.jupiter.api.Disabled;
2120

2221
import ch.qos.logback.classic.spi.ILoggingEvent;
2322
import io.reactivex.Completable;
@@ -2584,14 +2583,14 @@ public void throwFromOnHandlerRunsAllHandlers() {
25842583
value2.set(param1);
25852584
}, String.class);
25862585

2587-
hubConnection.start().timeout(1, TimeUnit.SECONDS).blockingAwait();
2586+
hubConnection.start().timeout(30, TimeUnit.SECONDS).blockingAwait();
25882587
mockTransport.receiveMessage("{\"type\":1,\"target\":\"inc\",\"arguments\":[\"Hello World\"]}" + RECORD_SEPARATOR);
25892588

25902589
// Confirming that our handler was called and the correct message was passed in.
25912590
assertEquals("Hello World", value1.get());
25922591
assertEquals("Hello World", value2.get());
25932592

2594-
hubConnection.stop().timeout(1, TimeUnit.SECONDS).blockingAwait();
2593+
hubConnection.stop().timeout(30, TimeUnit.SECONDS).blockingAwait();
25952594

25962595
ILoggingEvent log = logger.assertLog("Invoking client side method 'inc' failed:");
25972596
assertEquals("throw from on handler", log.getThrowableProxy().getMessage());
@@ -3192,15 +3191,14 @@ public void stopWithoutObservingWithLongPollingTransportStops() {
31923191
closed.onComplete();
31933192
});
31943193

3195-
hubConnection.start().timeout(1, TimeUnit.SECONDS).blockingAwait();
3194+
hubConnection.start().timeout(30, TimeUnit.SECONDS).blockingAwait();
31963195

31973196
hubConnection.stop();
3198-
closed.timeout(1, TimeUnit.SECONDS).blockingAwait();
3197+
closed.timeout(30, TimeUnit.SECONDS).blockingAwait();
31993198
blockGet.onComplete();
32003199
assertEquals(HubConnectionState.DISCONNECTED, hubConnection.getConnectionState());
32013200
}
32023201

3203-
@Disabled
32043202
@Test
32053203
public void hubConnectionClosesAndRunsOnClosedCallbackAfterCloseMessageWithLongPolling() {
32063204
AtomicInteger requestCount = new AtomicInteger(0);
@@ -3231,12 +3229,12 @@ public void hubConnectionClosesAndRunsOnClosedCallbackAfterCloseMessageWithLongP
32313229
hubConnection.onClosed((ex) -> {
32323230
closed.onComplete();
32333231
});
3234-
hubConnection.start().timeout(1, TimeUnit.SECONDS).blockingAwait();
3232+
hubConnection.start().timeout(30, TimeUnit.SECONDS).blockingAwait();
32353233

32363234
assertEquals(HubConnectionState.CONNECTED, hubConnection.getConnectionState());
32373235
blockGet.onComplete();
32383236

3239-
closed.timeout(1, TimeUnit.SECONDS).blockingAwait();
3237+
closed.timeout(30, TimeUnit.SECONDS).blockingAwait();
32403238

32413239
assertEquals(HubConnectionState.DISCONNECTED, hubConnection.getConnectionState());
32423240
}

src/SignalR/clients/java/signalr/test/src/main/java/com/microsoft/signalr/LongPollingTransportTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,7 @@ public void ErrorFromClosePropagatesOnSecondStopCall() {
392392
Map<String, String> headers = new HashMap<>();
393393
LongPollingTransport transport = new LongPollingTransport(headers, client, Single.just(""));
394394

395-
transport.start("http://example.com").timeout(100, TimeUnit.SECONDS).blockingAwait();
395+
transport.start("http://example.com").timeout(30, TimeUnit.SECONDS).blockingAwait();
396396

397397
RuntimeException exception = assertThrows(RuntimeException.class, () -> transport.stop().blockingAwait(100, TimeUnit.SECONDS));
398398
assertEquals("Request has no handler: DELETE http://example.com", exception.getMessage());

0 commit comments

Comments
 (0)