Increase SignalR Java client test timeouts to 30 seconds #25639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/dnceng/public/_build/results?buildId=803044&view=logs&jobId=6c33d704-163a-5170-38fa-caa7bc99f17c&j=6c33d704-163a-5170-38fa-caa7bc99f17c&t=4a2ac175-72f0-54eb-c8b6-eb1e5d86c7d5
A test timeout failure caused PR checks to fail for a recent automated merge PR (#25555).
Since there's no way to quarantine Java tests, I'm increasing the test timeouts from 1 second to 30 seconds. The timeout being too short might not be the ultimate cause of the flakiness, but waiting longer for timeouts would only slow down failures which shouldn't be too common. Kestrel has successfully used 30 second test timeouts to avoid unnecessary flakiness for years.
aspnetcore/src/Servers/Kestrel/shared/test/TestConstants.cs
Line 11 in 1e7d6d5