Skip to content

Conversation

@halter73
Copy link
Member

@halter73 halter73 commented Sep 4, 2020

JUnit Jupiter:HubConnectionTest:LongPollingTransportAccessTokenProviderThrowsAfterHandshakeClosesConnection()
    MethodSource [className = 'com.microsoft.signalr.HubConnectionTest', methodName = 'LongPollingTransportAccessTokenProviderThrowsAfterHandshakeClosesConnection', methodParameterTypes = '']
    => java.lang.RuntimeException: java.util.concurrent.TimeoutException: The source did not signal an event for 1 seconds and has been terminated.

https://dev.azure.com/dnceng/public/_build/results?buildId=803044&view=logs&jobId=6c33d704-163a-5170-38fa-caa7bc99f17c&j=6c33d704-163a-5170-38fa-caa7bc99f17c&t=4a2ac175-72f0-54eb-c8b6-eb1e5d86c7d5

A test timeout failure caused PR checks to fail for a recent automated merge PR (#25555).

Since there's no way to quarantine Java tests, I'm increasing the test timeouts from 1 second to 30 seconds. The timeout being too short might not be the ultimate cause of the flakiness, but waiting longer for timeouts would only slow down failures which shouldn't be too common. Kestrel has successfully used 30 second test timeouts to avoid unnecessary flakiness for years.

public static TimeSpan DefaultTimeout = TimeSpan.FromSeconds(30);

@ghost ghost added the area-signalr Includes: SignalR clients and servers label Sep 4, 2020
@halter73
Copy link
Member Author

halter73 commented Sep 8, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-signalr Includes: SignalR clients and servers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants