[Xamarin.Android.Build.Tasks] @(AndroidEnvironment) in lib dir #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 8a703c6 had the right idea, but read the `__AndroidEnvironment__*` files from the *wrong directory*. (This wasn't caught in the PR because, for never adequately explained reasons, the PR *never ran on the required machine*.) Specifically, commit 8a703c6 looks for `__AndroidEnvironment__*` files within `{outDirForDll}/{ImportsDir}`, which would be e.g. `obj/Debug/lp/0/jl`, which will *never* contain these files. Previously extracted `__AndroidEnvironment__*` files need to instead be looked for within the `outDirForDll` directory, e.g. `obj/Debug/lp/0`. Update the "cached" directory read logic to use the appropriate path.
dellis1972
approved these changes
Aug 15, 2017
jonpryor
added a commit
that referenced
this pull request
Aug 15, 2017
Commit 8a703c6 had the right idea, but read the `__AndroidEnvironment__*` files from the *wrong directory*. (This wasn't caught in the PR because, for never adequately explained reasons, the PR *never ran on the required machine*.) Specifically, commit 8a703c6 looks for `__AndroidEnvironment__*` files within `{outDirForDll}/{ImportsDir}`, which would be e.g. `obj/Debug/lp/0/jl`, which will *never* contain these files. Previously extracted `__AndroidEnvironment__*` files need to instead be looked for within the `outDirForDll` directory, e.g. `obj/Debug/lp/0`. Update the "cached" directory read logic to use the appropriate path.
jonpryor
pushed a commit
that referenced
this pull request
Nov 11, 2020
Fixes: #5251 Context: dotnet/java-interop@99897b2 Changes: dotnet/java-interop@c3c3575...99897b2 * dotnet/java-interop@99897b24: [jcw-gen] Do not register static methods on an interface. (#745) * dotnet/java-interop@54ba3c33: [.JavaSource, .ApiXmlAdjuster] Use Nullable Reference Types (#746) * dotnet/java-interop@b588ef50: [java-source-utils] Add response file support (#744) Adds a test for `static` methods on an interface that is implemented by a class. Our existing `static` test was an interface that only contained `static` members, and thus we did not try to implement the interface. Implementing the interface exposed a JCW error.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jan 4, 2021
Changes: dotnet/java-interop@2f62ffd...7574f16 * dotnet/java-interop@7574f166: [generator] Add `generator --with-javadoc-xml=FILE` support. (dotnet#687) * dotnet/java-interop@7d197f17: Refactor Crc64 type (dotnet#769) * dotnet/java-interop@876442f4: [generator] Fix MSBuild warning/error format for Visual Studio (dotnet#765) * dotnet/java-interop@3f6cf72b: [.Localization, .Cecil, .Diagnostics, .Generator] $(Nullable)=enable (dotnet#746) dotnet/java-interop#687 was merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 8a703c6 had the right idea, but read the
__AndroidEnvironment__*files from the wrong directory.(This wasn't caught in the PR because, for never adequately explained
reasons, the PR never ran on the required machine.)
Specifically, commit 8a703c6 looks for
__AndroidEnvironment__*files within
{outDirForDll}/{ImportsDir}, which would be e.g.obj/Debug/lp/0/jl, which will never contain these files.Previously extracted
__AndroidEnvironment__*files need to insteadbe looked for within the
outDirForDlldirectory, e.g.obj/Debug/lp/0.Update the "cached" directory read logic to use the appropriate path.