[Xamarin.Android.Build.Tasks] [Smoke][VS 2017] Exception on deploying CheeseSquare sample #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CheeseSquare sample Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58721 The initial problem seems to stem from the fact that for the support library components now directly include the resources. As a result the `_GenerateJavaResourcesForComponent` was not running. This was because it was only running if `_AdditonalAndroidResourceCachePaths` was not empty. In this scenario it was always empty. As a result none of the files like R.java files were generated for the support libraries. The means the final .class files did not have references for the R$drawable.foo identifiers. This results in a crash. So to fix the problem we need to start looking at the `@(LibraryResourceDirectories)` to see if we have any AndroidManifest.xml files. We should then process these directories to ensure that the R.java files are created. The finally compiled into the final applications.
jonpryor
pushed a commit
that referenced
this pull request
Aug 14, 2017
) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58721 The initial problem seems to stem from the fact that for the support library components now directly include the resources. As a result the `_GenerateJavaResourcesForComponent` target was not running. This was because it was only running if `$(_AdditonalAndroidResourceCachePaths)` was not empty. In this scenario it was always empty. As a result none of the files like `R.java` files were generated for the support libraries. The means the final `.class` files did not have references for the `R$drawable.foo` identifiers. This results in a crash: Java.Lang.NoClassDefFoundError: Failed resolution of: Landroid/support/v7/appcompat/R$drawable; Fix the problem by looking at `@(LibraryResourceDirectories)` to see if we have any `AndroidManifest.xml` files. We should then process these directories to ensure that the `R.java` files are created and included compiled into the final applications.
jonpryor
pushed a commit
that referenced
this pull request
Nov 11, 2020
Fixes: #5251 Context: dotnet/java-interop@99897b2 Changes: dotnet/java-interop@c3c3575...99897b2 * dotnet/java-interop@99897b24: [jcw-gen] Do not register static methods on an interface. (#745) * dotnet/java-interop@54ba3c33: [.JavaSource, .ApiXmlAdjuster] Use Nullable Reference Types (#746) * dotnet/java-interop@b588ef50: [java-source-utils] Add response file support (#744) Adds a test for `static` methods on an interface that is implemented by a class. Our existing `static` test was an interface that only contained `static` members, and thus we did not try to implement the interface. Implementing the interface exposed a JCW error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58721
The initial problem seems to stem from the fact that for the
support library components now directly include the resources.
As a result the
_GenerateJavaResourcesForComponentwas notrunning. This was because it was only running if
_AdditonalAndroidResourceCachePathswas not empty.In this scenario it was always empty.
As a result none of the files like R.java files were generated
for the support libraries. The means the final .class files
did not have references for the R$drawable.foo identifiers.
This results in a crash.
So to fix the problem we need to start looking at the
@(LibraryResourceDirectories)to see if we have anyAndroidManifest.xml files. We should then process these
directories to ensure that the R.java files are created.
The finally compiled into the final applications.