[Xamarin.Android.Build.Tasks] SlidingMenuExample project now fails to build against 15.4 with dozens of javac errors 'package foo does not exist' #745
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… build against 15.4 with dozens of javac errors 'package foo does not exist' Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58727 In commit 0667a2b we neglected to take into account that any embedded libraries or environment files would be deleted when the zip was extracted. Commit ea6b9b4 fixed the issue for the Environment files. This commit will fix the issue for the .jar files. We also added a new test so this doesn't happen in future.
jonpryor
pushed a commit
that referenced
this pull request
Aug 14, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58727 In commit 0667a2b we neglected to take into account that any embedded libraries or environment files could be deleted when the zip was extracted. Commit ea6b9b4 fixed the issue for the Environment files. This commit will fix the issue for the .jar files. We also added a new test so this doesn't happen in future.
jonpryor
pushed a commit
that referenced
this pull request
Nov 11, 2020
Fixes: #5251 Context: dotnet/java-interop@99897b2 Changes: dotnet/java-interop@c3c3575...99897b2 * dotnet/java-interop@99897b24: [jcw-gen] Do not register static methods on an interface. (#745) * dotnet/java-interop@54ba3c33: [.JavaSource, .ApiXmlAdjuster] Use Nullable Reference Types (#746) * dotnet/java-interop@b588ef50: [java-source-utils] Add response file support (#744) Adds a test for `static` methods on an interface that is implemented by a class. Our existing `static` test was an interface that only contained `static` members, and thus we did not try to implement the interface. Implementing the interface exposed a JCW error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58727
In commit 0667a2b we neglected to take into account that any
embedded libraries or environment files would be deleted when
the zip was extracted. Commit ea6b9b4 fixed the issue for the
Environment files. This commit will fix the issue for the .jar
files.
We also added a new test so this doesn't happen in future.