[illink] Use Crc64Helper class #5452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#5451 apk size comparison, BuildReleaseArm64False test: > apkdiff -e dll$ before.apk after.apk Size difference in bytes ([*1] apk1 only, [*2] apk2 only): - 123 assemblies/Mono.Android.dll - Type Java.Interop.Tools.JavaCallableWrappers.Crc64 Type Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager - Method static string ToHash (string, System.Security.Cryptography.HashAlgorithm) + Method static string ToCrc64 (string) + Type Java.Interop.Tools.JavaCallableWrappers.Crc64Helper - 2,975 assemblies/System.Security.Cryptography.Primitives.dll *1 Summary: - 3,098 Assemblies -0.41% (of 749,039)
Member
Author
|
I think we might remove the |
Member
Author
|
This depends on dotnet/java-interop#769 |
Contributor
|
This PR (#5452) and dotnet/java-interop#769 were co-dependent: the merge of dotnet/java-interop#769 breaks Java.Interop bumps. Case in point: PR #5253 fails to build: …because |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jan 5, 2021
Context: dotnet/java-interop@7d197f1 Context: dotnet#5452 dotnet/java-interop@7d197f17 introduced build breakage: …/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.JavaCallableWrappers/Java.Interop.Tools.JavaCallableWrappers/Crc64.cs(58,16): error CS0117: 'Crc64Helper' does not contain a definition for 'HashCore' …/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs(648,27): error CS0117: 'Crc64Helper' does not contain a definition for 'Compute' PR dotnet#5452 has the fix. Include the build fix so that PR dotnet#5253 can build.
radekdoulik
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
grendello
approved these changes
Jan 5, 2021
dellis1972
approved these changes
Jan 5, 2021
jonathanpeppers
approved these changes
Jan 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #5451
apk size comparison, BuildReleaseArm64False test: